From: Bruce Richardson <bruce.richardson@intel.com>
To: Gavin Hu <gavin.hu@arm.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/2] mk: fix cross build errors
Date: Mon, 28 May 2018 14:24:02 +0100 [thread overview]
Message-ID: <20180528132402.GC8752@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1527490428-15540-1-git-send-email-gavin.hu@arm.com>
On Mon, May 28, 2018 at 02:53:47AM -0400, Gavin Hu wrote:
> The "-Wimplicit-fallthrough=2" option was introduced into gcc 7.0, it was
> enabled when the cross compiler gcc is greater than 7.0, but for the host
> side buildtools/pmdinfogen, if the native is older than 7.0, it should not
> be enabled.
>
> The fix is to differentiate the host gcc Werror options from the cross gcc.
>
> gcc -Wp,-MD,./.pmdinfogen.o.d.tmp -W -Wall -Wstrict-prototypes
> -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition
> -Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual
> -Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings -Wdeprecated
> -Werror -Wimplicit-fallthrough=2 -Dbbb -Wno-format-truncation -g
> -I/home/gavin/arm_repo/dpdk/build/include -o pmdinfogen.o -c
> ~/dpdk/buildtools/pmdinfogen/pmdinfogen.c gcc: error:
> unrecognized command line option ‘-Wimplicit-fallthrough=2’
> ~/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'pmdinfogen.o'
> failed make[3]: *** [pmdinfogen.o] Error 1
>
> Fixes: ced3e6f8 ("mk: adjust gcc flags for new gcc 7 warnings")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Reviewed-by: Steve Capper <Steve.Capper@arm.com>
> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Would a simpler solution for this not be to put "-Wno-implicit-fallthrough"
for pmdinfogen? GCC will not give a warning for an unrecognised "-Wno"
flag when compiling, unless there are other errors. This means we can just
use the flag without bothering with version checks.
/Bruce
next prev parent reply other threads:[~2018-05-28 13:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1527133127-29407-1-git-send-email-gavin.hu@arm.com>
2018-05-24 3:38 ` [dpdk-stable] [PATCH " Gavin Hu
2018-05-28 6:53 ` [dpdk-stable] [PATCH v2 " Gavin Hu
2018-05-28 13:24 ` Bruce Richardson [this message]
2018-05-29 1:22 ` [dpdk-stable] [dpdk-dev] " Gavin Hu
2018-05-29 6:51 ` [dpdk-stable] [PATCH v3 " Gavin Hu
[not found] ` <1527578508-27297-1-git-send-email-gavin.hu@arm.com>
2018-05-29 7:21 ` [dpdk-stable] [PATCH v4 " Gavin Hu
[not found] ` <1527590616-28299-1-git-send-email-gavin.hu@arm.com>
2018-05-29 10:43 ` [dpdk-stable] [PATCH v5 " Gavin Hu
2018-05-29 15:09 ` Thomas Monjalon
[not found] ` <20180614095127.16245-1-gavin.hu@arm.com>
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 1/7] " Gavin Hu
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 3/7] devtools: fix the Exec format error Gavin Hu
2018-06-14 10:34 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15 8:07 ` Gavin Hu
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 4/7] build: fix the meson build warning Gavin Hu
2018-06-14 10:34 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 5/7] devtools: fix the missing ninja command error on CentOS Gavin Hu
2018-06-14 10:40 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15 8:08 ` Gavin Hu
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 6/7] build: fix the meson cross compile error Gavin Hu
2018-06-14 10:42 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 7/7] devtools: expand meson cross compiling coverage Gavin Hu
2018-06-14 10:45 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15 8:09 ` Gavin Hu
2018-06-15 10:23 ` Gavin Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528132402.GC8752@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).