From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, shahafs@mellanox.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix error number handling
Date: Tue, 5 Jun 2018 08:52:46 +0200 [thread overview]
Message-ID: <20180605065246.mw7xnk24cfwxy4an@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <20180604173731.29125-1-yskoh@mellanox.com>
On Mon, Jun 04, 2018 at 10:37:31AM -0700, Yongseok Koh wrote:
> rte_errno should be saved only if error has occurred because rte_errno
> could have garbage value.
>
> Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 994be05be..eaffe7495 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -3561,7 +3561,8 @@ mlx5_fdir_filter_delete(struct rte_eth_dev *dev,
> /* The flow does not match. */
> continue;
> }
> - ret = rte_errno; /* Save rte_errno before cleanup. */
> + if (ret)
> + ret = rte_errno; /* Save rte_errno before cleanup. */
> if (flow)
> mlx5_flow_list_destroy(dev, &priv->flows, flow);
> exit:
> --
> 2.11.0
This patch is not enough, the returned value being -rte_errno if no
error is detected by the function it cannot set rte_errno nor return it.
Thanks,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-06-05 6:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 17:37 Yongseok Koh
2018-06-05 6:52 ` Nélio Laranjeiro [this message]
2018-06-05 21:36 ` Yongseok Koh
2018-06-06 6:55 ` Nélio Laranjeiro
2018-06-06 18:39 ` Yongseok Koh
2018-06-07 7:39 ` Nélio Laranjeiro
2018-06-18 17:06 ` Yongseok Koh
2018-06-19 11:48 ` Nélio Laranjeiro
2018-06-19 23:00 ` Yongseok Koh
2018-06-20 7:05 ` Nélio Laranjeiro
2018-06-19 23:13 ` [dpdk-stable] [PATCH v2] " Yongseok Koh
2018-06-20 7:02 ` Nélio Laranjeiro
2018-06-21 10:57 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605065246.mw7xnk24cfwxy4an@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).