From: Stephen Hemminger <stephen@networkplumber.org>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: "Wiles, Keith" <keith.wiles@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH v10 1/5] eal: add rte_uuid support
Date: Mon, 11 Jun 2018 10:35:08 -0700 [thread overview]
Message-ID: <20180611103508.6893e6ee@xeon-e3> (raw)
In-Reply-To: <20180610111640.GA7050@jerin>
On Sun, 10 Jun 2018 16:46:42 +0530
Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:
> -----Original Message-----
> > Date: Fri, 8 Jun 2018 11:11:54 -0700
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > To: "Wiles, Keith" <keith.wiles@intel.com>
> > Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger
> > <sthemmin@microsoft.com>
> > Subject: Re: [dpdk-dev] [PATCH v10 1/5] eal: add rte_uuid support
> >
> > On Fri, 8 Jun 2018 17:15:04 +0000
> > "Wiles, Keith" <keith.wiles@intel.com> wrote:
> >
> > > > On Jun 8, 2018, at 9:59 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> > > >
> > > > Since uuid functions may not be available everywhere, implement
> > > > uuid functions in DPDK. These are based off the BSD licensed
> > > > libuuid in util-link.
> > > >
> > > > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> > > > ---
> > > > lib/librte_eal/bsdapp/eal/Makefile | 1 +
> > > > lib/librte_eal/common/Makefile | 2 +-
> > > > lib/librte_eal/common/eal_common_uuid.c | 193 +++++++++++++++++++++++
> > > > lib/librte_eal/common/include/rte_uuid.h | 129 +++++++++++++++
> > > > lib/librte_eal/common/meson.build | 2 +
> > > > lib/librte_eal/linuxapp/eal/Makefile | 1 +
> > > > lib/librte_eal/rte_eal_version.map | 9 ++
> > > > 7 files changed, 336 insertions(+), 1 deletion(-)
> > > > create mode 100644 lib/librte_eal/common/eal_common_uuid.c
> > > > create mode 100644 lib/librte_eal/common/include/rte_uuid.h
> > > >
> > >
> > > Hi Stephen, Why does this need to be in EAl/Common would this be better in the lib directory for utils or string routines? Does the EAl use the feature for something?
> > >
> > > Regards,
> > > Keith
> > >
> >
> > It could be anywhere. Not tied to being in EAL common but that is where the PCI parsing code is.
> > Still not 100% sure we need our own version of this simple code. It is more about BSD and eventually Windows support.
>
>
> IMO, It is useful to add it in common EAL as some drivers can also use it.
> But, I think, we must add unit test case for this new API.
>
I don't see much point in going through the effort of writing unit test since it is just a straight
copy of Ted's uuid code which has been around for a long time.
next prev parent reply other threads:[~2018-06-11 17:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 16:59 [dpdk-dev] [PATCH v10 0/5] Hyper-V/Azure netvsc PMD and bus support Stephen Hemminger
2018-06-08 16:59 ` [dpdk-dev] [PATCH v10 1/5] eal: add rte_uuid support Stephen Hemminger
2018-06-08 17:15 ` Wiles, Keith
2018-06-08 18:11 ` Stephen Hemminger
2018-06-10 11:16 ` Jerin Jacob
2018-06-11 17:35 ` Stephen Hemminger [this message]
2018-06-08 16:59 ` [dpdk-dev] [PATCH v10 2/5] bus/vmbus: add hyper-v virtual bus support Stephen Hemminger
2018-06-08 16:59 ` [dpdk-dev] [PATCH v10 3/5] net/netvsc: add hyper-v netvsc network device Stephen Hemminger
2018-06-08 16:59 ` [dpdk-dev] [PATCH v10 4/5] net/netvsc: add documentation Stephen Hemminger
2018-06-08 16:59 ` [dpdk-dev] [PATCH v10 5/5] bus/vmbus and net/netvsc: add meson build support Stephen Hemminger
2018-06-12 15:21 ` [dpdk-dev] [PATCH v10 0/5] Hyper-V/Azure netvsc PMD and bus support Thomas Monjalon
2018-06-12 15:43 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611103508.6893e6ee@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=keith.wiles@intel.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).