From: Bruce Richardson <bruce.richardson@intel.com>
To: Gavin Hu <gavin.hu@arm.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v6 5/7] devtools: fix the missing ninja command error on CentOS
Date: Thu, 14 Jun 2018 11:40:30 +0100 [thread overview]
Message-ID: <20180614104030.GC17264@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20180614095127.16245-6-gavin.hu@arm.com>
On Thu, Jun 14, 2018 at 05:51:25PM +0800, Gavin Hu wrote:
> On CentOS, the ninja executable has a different name:
> ninja-build, this patch is to fix the missing command error
> on CentOS as follows:
> ./devtools/test-meson-builds.sh: line 24: ninja: command not found
>
> Fixes: a55277a788 ("devtools: add test script for meson builds")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Song Zhu <song.zhu@arm.com>
> ---
> devtools/test-meson-builds.sh | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index 6bce3df7f..4afac76dd 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -21,7 +21,11 @@ build () # <directory> <meson options>
> $MESON $options $srcdir $builddir
> fi
> echo "ninja -C $builddir"
> - ninja -C $builddir
> + if [ "$(lsb_release -d | grep -c 'CentOS')" != "0" ] ; then
> + ninja-build -C $builddir
> + else
> + ninja -C $builddir
> + fi
> }
Rather than tying this to CentOS explicitly, would it be better at the
start of the script to test e.g "which ninja" and "which ninja-build" and
use that to work out the command to use. It's possible to have ninja
installed directly from tarball on CentOS as "ninja" (as I have in my test
VM), and the binary might be called ninja-build on other systems too e.g.
RHEL, perhaps.
/Bruce
next prev parent reply other threads:[~2018-06-14 10:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1527133127-29407-1-git-send-email-gavin.hu@arm.com>
2018-05-24 3:38 ` [dpdk-stable] [PATCH 1/2] mk: fix cross build errors Gavin Hu
2018-05-28 6:53 ` [dpdk-stable] [PATCH v2 " Gavin Hu
2018-05-28 13:24 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-05-29 1:22 ` Gavin Hu
2018-05-29 6:51 ` [dpdk-stable] [PATCH v3 " Gavin Hu
[not found] ` <1527578508-27297-1-git-send-email-gavin.hu@arm.com>
2018-05-29 7:21 ` [dpdk-stable] [PATCH v4 " Gavin Hu
[not found] ` <1527590616-28299-1-git-send-email-gavin.hu@arm.com>
2018-05-29 10:43 ` [dpdk-stable] [PATCH v5 " Gavin Hu
2018-05-29 15:09 ` Thomas Monjalon
[not found] ` <20180614095127.16245-1-gavin.hu@arm.com>
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 1/7] " Gavin Hu
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 3/7] devtools: fix the Exec format error Gavin Hu
2018-06-14 10:34 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15 8:07 ` Gavin Hu
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 4/7] build: fix the meson build warning Gavin Hu
2018-06-14 10:34 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 5/7] devtools: fix the missing ninja command error on CentOS Gavin Hu
2018-06-14 10:40 ` Bruce Richardson [this message]
2018-06-15 8:08 ` [dpdk-stable] [dpdk-dev] " Gavin Hu
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 6/7] build: fix the meson cross compile error Gavin Hu
2018-06-14 10:42 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 7/7] devtools: expand meson cross compiling coverage Gavin Hu
2018-06-14 10:45 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15 8:09 ` Gavin Hu
2018-06-15 10:23 ` Gavin Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614104030.GC17264@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).