From: Bruce Richardson <bruce.richardson@intel.com>
To: Gavin Hu <gavin.hu@arm.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v6 6/7] build: fix the meson cross compile error
Date: Thu, 14 Jun 2018 11:42:51 +0100 [thread overview]
Message-ID: <20180614104250.GD17264@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20180614095127.16245-7-gavin.hu@arm.com>
On Thu, Jun 14, 2018 at 05:51:26PM +0800, Gavin Hu wrote:
> The following error hits if host cc compiler is clang(default one in most
> linux distributions) and the cross compiler is gcc.
>
> The root cause is: the hybride compilers add the warning options to the
> meson project as project arguments, which apply for both host compiling and
> cross compiling. But some options such as '-Wno-format-truncation' are not
> supported nor recognized by clang, so they have to be removed from the
> project arguments for the host compiler to run smoothily and added back as
> cflags for the cross compiler to compile for cross source files.
>
> The fix is remove unrecognized warning options from the meson project
> arguments shared by gcc and clang, as add them specifically for gcc or
> clang as cflags.
>
> [265/893] Compiling C object
> 'buildtools/pmdinfogen/pmdinfogen@exe/pmdinfogen.c.o'. warning: unknown
> warning option '-Wno-format-truncation' [-Wunknown-warning-option]
>
> Fixes: a55277a788 ("devtools: add test script for meson builds")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Song Zhu <song.zhu@arm.com>
> Reviewed-by: Steve Capper <Steve.Capper@arm.com>
> ---
Yes, I think this solution works. A cleaner fix might be to move away from
having these flags as meson project arguments, and instead manage them
directly in our files as arrays of native and cross cflags, but that can be
a job for later. As it is:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2018-06-14 10:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1527133127-29407-1-git-send-email-gavin.hu@arm.com>
2018-05-24 3:38 ` [dpdk-stable] [PATCH 1/2] mk: fix cross build errors Gavin Hu
2018-05-28 6:53 ` [dpdk-stable] [PATCH v2 " Gavin Hu
2018-05-28 13:24 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-05-29 1:22 ` Gavin Hu
2018-05-29 6:51 ` [dpdk-stable] [PATCH v3 " Gavin Hu
[not found] ` <1527578508-27297-1-git-send-email-gavin.hu@arm.com>
2018-05-29 7:21 ` [dpdk-stable] [PATCH v4 " Gavin Hu
[not found] ` <1527590616-28299-1-git-send-email-gavin.hu@arm.com>
2018-05-29 10:43 ` [dpdk-stable] [PATCH v5 " Gavin Hu
2018-05-29 15:09 ` Thomas Monjalon
[not found] ` <20180614095127.16245-1-gavin.hu@arm.com>
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 1/7] " Gavin Hu
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 3/7] devtools: fix the Exec format error Gavin Hu
2018-06-14 10:34 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15 8:07 ` Gavin Hu
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 4/7] build: fix the meson build warning Gavin Hu
2018-06-14 10:34 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 5/7] devtools: fix the missing ninja command error on CentOS Gavin Hu
2018-06-14 10:40 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15 8:08 ` Gavin Hu
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 6/7] build: fix the meson cross compile error Gavin Hu
2018-06-14 10:42 ` Bruce Richardson [this message]
2018-06-14 9:51 ` [dpdk-stable] [PATCH v6 7/7] devtools: expand meson cross compiling coverage Gavin Hu
2018-06-14 10:45 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15 8:09 ` Gavin Hu
2018-06-15 10:23 ` Gavin Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614104250.GD17264@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).