From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Awal, Mohammad Abdul" <mohammad.abdul.awal@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: add NVGRE encap/decap support
Date: Fri, 15 Jun 2018 13:25:45 +0200 [thread overview]
Message-ID: <20180615112545.cnwnx7mxk4sld3a6@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CB3BE9@IRSMSX108.ger.corp.intel.com>
Hi Bernard,
On Fri, Jun 15, 2018 at 09:32:02AM +0000, Iremonger, Bernard wrote:
> Hi Nelio,
>
>[...]
> > @@ -14927,6 +14930,81 @@ cmdline_parse_inst_t cmd_set_vxlan = {
> > },
> > };
> >
> > +/** Set VXLAN encapsulation details */
>
> VXLAN should be NVGRE.
>[...]
Right,
> > b/app/test-pmd/testpmd.c index 1c68c9d30..f54205949 100644
> > --- a/app/test-pmd/testpmd.c
> > +++ b/app/test-pmd/testpmd.c
> > @@ -408,6 +408,15 @@ struct vxlan_encap_conf vxlan_encap_conf = {
> > .eth_dst = "\xff\xff\xff\xff\xff\xff", };
> >
> > +struct nvgre_encap_conf nvgre_encap_conf = {
> > + .select_ipv4 = 1,
> > + .tni = "\x00\x00\x00",
> > + .ipv4_src = IPv4(127, 0, 0, 1),
> > + .ipv4_dst = IPv4(255, 255, 255, 255),
>
> Should there be .ipv6_src and .ipv6_dst here ?
>[...]
Yes indeed initialisation of IPv6 is missing.
> > +- ``nvgre_decap``: Performs a decapsulation action by stripping all
> > +headers of
> > + the VXLAN tunnel network overlay from the matched flow.
>
> VXLAN should be NVGRE.
>
>[...]
Here also,
I am will update it in a V2.
Thanks for you review,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-06-15 11:25 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 15:08 [dpdk-dev] [PATCH 0/2] implement VXLAN/NVGRE Encap/Decap in testpmd Nelio Laranjeiro
2018-06-14 15:08 ` [dpdk-dev] [PATCH 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-14 15:09 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-15 9:32 ` Iremonger, Bernard
2018-06-15 11:25 ` Nélio Laranjeiro [this message]
2018-06-18 8:52 ` [dpdk-dev] [PATCH v2 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Nelio Laranjeiro
2018-06-18 9:05 ` Ferruh Yigit
2018-06-18 9:38 ` Nélio Laranjeiro
2018-06-18 14:40 ` Ferruh Yigit
2018-06-19 7:32 ` Nélio Laranjeiro
2018-06-18 14:36 ` [dpdk-dev] [PATCH v3 " Nelio Laranjeiro
2018-06-18 16:28 ` Iremonger, Bernard
2018-06-19 9:41 ` Nélio Laranjeiro
2018-06-21 7:13 ` [dpdk-dev] [PATCH v4 " Nelio Laranjeiro
2018-06-21 7:13 ` [dpdk-dev] [PATCH v4 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-26 10:51 ` Ori Kam
2018-06-26 12:43 ` Iremonger, Bernard
2018-06-21 7:13 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-26 10:48 ` Ori Kam
2018-06-26 12:48 ` Iremonger, Bernard
2018-06-26 15:15 ` Nélio Laranjeiro
2018-06-22 7:42 ` [dpdk-dev] [PATCH v4 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Mohammad Abdul Awal
2018-06-22 8:31 ` Nélio Laranjeiro
2018-06-22 8:51 ` Mohammad Abdul Awal
2018-06-22 9:08 ` Nélio Laranjeiro
2018-06-22 10:19 ` Mohammad Abdul Awal
2018-06-26 15:15 ` Nélio Laranjeiro
2018-06-27 8:53 ` [dpdk-dev] [PATCH v5 " Nelio Laranjeiro
2018-06-27 8:53 ` [dpdk-dev] [PATCH v5 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-27 8:53 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-27 9:53 ` [dpdk-dev] [PATCH v6 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Nelio Laranjeiro
2018-06-27 9:53 ` [dpdk-dev] [PATCH v6 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-27 9:53 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-27 10:00 ` [dpdk-dev] [PATCH v6 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Nélio Laranjeiro
2018-06-27 11:45 ` [dpdk-dev] [PATCH v7 " Nelio Laranjeiro
2018-06-27 11:45 ` [dpdk-dev] [PATCH v7 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-27 11:45 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-07-02 10:40 ` [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Mohammad Abdul Awal
2018-07-04 14:54 ` Ferruh Yigit
2018-07-05 9:37 ` Nélio Laranjeiro
2018-07-05 14:33 ` [dpdk-dev] [PATCH v8 " Nelio Laranjeiro
2018-07-05 14:33 ` [dpdk-dev] [PATCH v8 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-07-05 15:03 ` Mohammad Abdul Awal
2018-07-05 14:33 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-07-05 15:07 ` Mohammad Abdul Awal
2018-07-05 15:17 ` Nélio Laranjeiro
2018-07-05 14:48 ` [dpdk-dev] [PATCH v8 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Adrien Mazarguil
2018-07-05 14:57 ` Mohammad Abdul Awal
2018-07-06 6:43 ` [dpdk-dev] [PATCH v9 " Nelio Laranjeiro
2018-07-06 6:43 ` [dpdk-dev] [PATCH v9 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-07-06 6:43 ` [dpdk-dev] [PATCH v9 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-07-18 8:31 ` [dpdk-dev] [PATCH v9 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Ferruh Yigit
2018-06-18 14:36 ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-19 7:09 ` Ori Kam
2018-06-19 9:40 ` Nélio Laranjeiro
2018-06-18 14:36 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-19 7:08 ` Ori Kam
2018-06-18 8:52 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN " Nelio Laranjeiro
2018-06-18 12:47 ` Mohammad Abdul Awal
2018-06-18 21:02 ` Stephen Hemminger
2018-06-19 9:44 ` Nélio Laranjeiro
2018-06-18 8:52 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-18 12:48 ` Mohammad Abdul Awal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615112545.cnwnx7mxk4sld3a6@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=mohammad.abdul.awal@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).