DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,
	Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Bernard Iremonger <bernard.iremonger@intel.com>,
	Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN encap/decap support
Date: Mon, 18 Jun 2018 14:02:10 -0700	[thread overview]
Message-ID: <20180618140210.431f2771@xeon-e3> (raw)
In-Reply-To: <9356cee477d0d3ea3984f3bafee032d92554a7e0.1529311722.git.nelio.laranjeiro@6wind.com>

On Mon, 18 Jun 2018 10:52:54 +0200
Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:

>  
> +struct vxlan_encap_conf vxlan_encap_conf = {
> +	.select_ipv4 = 1,
> +	.vni = "\x00\x00\x00",
> +	.udp_src = RTE_BE16(1),

Overall looks good. One enhancement I would suggest is to implement generating
the UDP source port based on a hash of fields from inner packet (as suggested
in RFC 7348).  This would be enabled by default (use udp source port of 0
as a flag to enable it).

  parent reply	other threads:[~2018-06-18 21:02 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 15:08 [dpdk-dev] [PATCH 0/2] implement VXLAN/NVGRE Encap/Decap in testpmd Nelio Laranjeiro
2018-06-14 15:08 ` [dpdk-dev] [PATCH 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-14 15:09 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-15  9:32   ` Iremonger, Bernard
2018-06-15 11:25     ` Nélio Laranjeiro
2018-06-18  8:52 ` [dpdk-dev] [PATCH v2 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Nelio Laranjeiro
2018-06-18  9:05   ` Ferruh Yigit
2018-06-18  9:38     ` Nélio Laranjeiro
2018-06-18 14:40       ` Ferruh Yigit
2018-06-19  7:32         ` Nélio Laranjeiro
2018-06-18 14:36   ` [dpdk-dev] [PATCH v3 " Nelio Laranjeiro
2018-06-18 16:28     ` Iremonger, Bernard
2018-06-19  9:41       ` Nélio Laranjeiro
2018-06-21  7:13     ` [dpdk-dev] [PATCH v4 " Nelio Laranjeiro
2018-06-21  7:13       ` [dpdk-dev] [PATCH v4 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-26 10:51         ` Ori Kam
2018-06-26 12:43         ` Iremonger, Bernard
2018-06-21  7:13       ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-26 10:48         ` Ori Kam
2018-06-26 12:48         ` Iremonger, Bernard
2018-06-26 15:15           ` Nélio Laranjeiro
2018-06-22  7:42       ` [dpdk-dev] [PATCH v4 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Mohammad Abdul Awal
2018-06-22  8:31         ` Nélio Laranjeiro
2018-06-22  8:51           ` Mohammad Abdul Awal
2018-06-22  9:08             ` Nélio Laranjeiro
2018-06-22 10:19               ` Mohammad Abdul Awal
2018-06-26 15:15                 ` Nélio Laranjeiro
2018-06-27  8:53       ` [dpdk-dev] [PATCH v5 " Nelio Laranjeiro
2018-06-27  8:53         ` [dpdk-dev] [PATCH v5 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-27  8:53         ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-27  9:53         ` [dpdk-dev] [PATCH v6 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Nelio Laranjeiro
2018-06-27  9:53           ` [dpdk-dev] [PATCH v6 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-27  9:53           ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-27 10:00           ` [dpdk-dev] [PATCH v6 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Nélio Laranjeiro
2018-06-27 11:45           ` [dpdk-dev] [PATCH v7 " Nelio Laranjeiro
2018-06-27 11:45             ` [dpdk-dev] [PATCH v7 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-27 11:45             ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-07-02 10:40             ` [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Mohammad Abdul Awal
2018-07-04 14:54               ` Ferruh Yigit
2018-07-05  9:37                 ` Nélio Laranjeiro
2018-07-05 14:33             ` [dpdk-dev] [PATCH v8 " Nelio Laranjeiro
2018-07-05 14:33               ` [dpdk-dev] [PATCH v8 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-07-05 15:03                 ` Mohammad Abdul Awal
2018-07-05 14:33               ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-07-05 15:07                 ` Mohammad Abdul Awal
2018-07-05 15:17                   ` Nélio Laranjeiro
2018-07-05 14:48               ` [dpdk-dev] [PATCH v8 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Adrien Mazarguil
2018-07-05 14:57               ` Mohammad Abdul Awal
2018-07-06  6:43               ` [dpdk-dev] [PATCH v9 " Nelio Laranjeiro
2018-07-06  6:43                 ` [dpdk-dev] [PATCH v9 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-07-06  6:43                 ` [dpdk-dev] [PATCH v9 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-07-18  8:31                 ` [dpdk-dev] [PATCH v9 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Ferruh Yigit
2018-06-18 14:36   ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-19  7:09     ` Ori Kam
2018-06-19  9:40       ` Nélio Laranjeiro
2018-06-18 14:36   ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-19  7:08     ` Ori Kam
2018-06-18  8:52 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN " Nelio Laranjeiro
2018-06-18 12:47   ` Mohammad Abdul Awal
2018-06-18 21:02   ` Stephen Hemminger [this message]
2018-06-19  9:44     ` Nélio Laranjeiro
2018-06-18  8:52 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-18 12:48   ` Mohammad Abdul Awal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180618140210.431f2771@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=adrien.mazarguil@6wind.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=mohammad.abdul.awal@intel.com \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).