From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: Raslan Darawsheh <rasland@mellanox.com>,
Yongseok Koh <yskoh@mellanox.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix Rss level validation
Date: Wed, 20 Jun 2018 09:10:33 +0200 [thread overview]
Message-ID: <20180620071033.wxvqvtn4bbdbzcfk@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <DB7PR05MB44260B24B22D3BF4635300B4C3770@DB7PR05MB4426.eurprd05.prod.outlook.com>
On Wed, Jun 20, 2018 at 05:34:23AM +0000, Shahaf Shuler wrote:
> Adding the maintainers,
>
> Tuesday, June 19, 2018 4:09 PM, Raslan Darawsheh:
> >Subject: [PATCH] net/mlx5: fix Rss level validation
>
> Rss -> RSS
>
> >
> >When setting the level in rss action it's checking for the value stored in the
> >parser which is set to 0 by default.
> >
> >this change the check to be for the requested action insted.
>
> this -> This
> instead -> instead
>
> >
> >Fixes: d4a40518 ("net/mlx5: support tunnel RSS level")
> >
> >Cc: stable@dpdk.org
> >Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> >---
> > drivers/net/mlx5/mlx5_flow.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> >index 994be05..40df633 100644
> >--- a/drivers/net/mlx5/mlx5_flow.c
> >+++ b/drivers/net/mlx5/mlx5_flow.c
> >@@ -738,7 +738,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev,
> > return -rte_errno;
> > }
> > #ifndef HAVE_IBV_DEVICE_TUNNEL_SUPPORT
> >- if (parser->rss_conf.level > 1) {
> >+ if (rss->level > 1) {
> > rte_flow_error_set(error, EINVAL,
> >
> >RTE_FLOW_ERROR_TYPE_ACTION,
> > actions,
> >@@ -747,7 +747,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev,
> > return -rte_errno;
> > }
> > #endif
> >- if (parser->rss_conf.level > 2) {
> >+ if (rss->level > 2) {
> > rte_flow_error_set(error, EINVAL,
> >
> >RTE_FLOW_ERROR_TYPE_ACTION,
> > actions,
> >--
>
> The above changes (if they are the only one) can be address by me when I apply the patch.
> Will wait few days for the maintainers comments.
>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
We should answer the same as the other patches, there is already a
re-work remodeling the whole engine, this patch remains relevant for
stables branches, but no more for mainline.
Regards,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-06-20 7:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 13:08 Raslan Darawsheh
2018-06-20 5:34 ` Shahaf Shuler
2018-06-20 7:10 ` Nélio Laranjeiro [this message]
2018-06-21 7:30 ` [dpdk-stable] [PATCH v2] net/mlx5: fix RSS " Raslan Darawsheh
-- strict thread matches above, loose matches on Subject: below --
2018-06-19 13:07 [dpdk-stable] [PATCH] net/mlx5: fix Rss " Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620071033.wxvqvtn4bbdbzcfk@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).