From: Bruce Richardson <bruce.richardson@intel.com>
To: Choonho Son <choonho.son@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] usertools: fix build with gcc
Date: Thu, 21 Jun 2018 10:55:02 +0100 [thread overview]
Message-ID: <20180621095502.GA436@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1529573741-9606-2-git-send-email-choonho.son@gmail.com>
On Thu, Jun 21, 2018 at 09:35:41AM +0000, Choonho Son wrote:
> dpdk-setup.sh fails to build with lack of environment variable
>
> Build complete [x86_64-native-linuxapp-gcc]
> Installation cannot run with T defined and DESTDIR undefined
>
> Signed-off-by: Choonho Son <choonho.son@gmail.com>
> ---
> usertools/dpdk-setup.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh
> index 5eebbce..5248e7a 100755
> --- a/usertools/dpdk-setup.sh
> +++ b/usertools/dpdk-setup.sh
> @@ -65,6 +65,7 @@ setup_target()
> {
> option=$1
> export RTE_TARGET=${TARGETS[option]}
> + export DESTDIR=${DESTDIR:-install}
>
> compiler=${RTE_TARGET##*-}
> if [ "$compiler" == "icc" ] ; then
> @@ -76,7 +77,7 @@ setup_target()
> fi
> fi
> if [ "$QUIT" == "0" ] ; then
> - make install T=${RTE_TARGET}
> + make install T=${RTE_TARGET} DESTDIR=${DESTDIR}
> fi
> echo "------------------------------------------------------------------------------"
> echo " RTE_TARGET exported as $RTE_TARGET"
The message about no DESTDIR is not really an error, the build has
completed successfully. I don't think copying the build over to a new
directory is something we should always do as part of this script.
/Bruce
next prev parent reply other threads:[~2018-06-21 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 9:35 Choonho Son
2018-06-21 9:35 ` Choonho Son
2018-06-21 9:55 ` Bruce Richardson [this message]
2018-06-27 13:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621095502.GA436@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=choonho.son@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).