From: Tiwei Bie <tiwei.bie@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: "Wang, Zhihong" <zhihong.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 08/11] net/virtio: add in-order Rx/Tx into selection
Date: Sat, 30 Jun 2018 10:42:48 +0800 [thread overview]
Message-ID: <20180630024248.GA5834@debian> (raw)
In-Reply-To: <1d68616b-1408-7cf1-2591-72756a7a0cdd@redhat.com>
On Fri, Jun 29, 2018 at 10:04:23AM +0200, Maxime Coquelin wrote:
> On 06/28/2018 05:39 PM, Liu, Yong wrote:
> >
> >
> > > -----Original Message-----
> > > From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> > > Sent: Thursday, June 28, 2018 11:16 PM
> > > To: Liu, Yong <yong.liu@intel.com>; Bie, Tiwei <tiwei.bie@intel.com>
> > > Cc: Wang, Zhihong <zhihong.wang@intel.com>; dev@dpdk.org
> > > Subject: Re: [PATCH v3 08/11] net/virtio: add in-order Rx/Tx into
> > > selection
> > >
> > >
> > >
> > > On 06/28/2018 11:52 PM, Marvin Liu wrote:
> > > > After IN_ORDER Rx/Tx paths added, need to update Rx/Tx path selection
> > > > logic.
> > > >
> > > > Rx path select logic: If IN_ORDER is disabled will select normal Rx
> > > > path. If IN_ORDER is enabled, Rx offload and merge-able are disabled
> > > > will select simple Rx path. Otherwise will select IN_ORDER Rx path.
> > > >
> > > > Tx path select logic: If IN_ORDER is disabled will select normal Tx
> > > > path. If IN_ORDER is enabled and merge-able is disabled will select
> > > > simple Tx path. Otherwise will select IN_ORDER Tx path.
> > > >
> > > > Signed-off-by: Marvin Liu <yong.liu@intel.com>
> > > >
> > > > diff --git a/drivers/net/virtio/virtio_ethdev.c
> > > b/drivers/net/virtio/virtio_ethdev.c
> > > > index df50a571a..2b3d65f80 100644
> > > > --- a/drivers/net/virtio/virtio_ethdev.c
> > > > +++ b/drivers/net/virtio/virtio_ethdev.c
> > > > @@ -1320,6 +1320,11 @@ set_rxtx_funcs(struct rte_eth_dev *eth_dev)
> > > > PMD_INIT_LOG(INFO, "virtio: using simple Rx path on port %u",
> > > > eth_dev->data->port_id);
> > > > eth_dev->rx_pkt_burst = virtio_recv_pkts_vec;
> > > > + } else if (hw->use_inorder_rx) {
> > > > + PMD_INIT_LOG(INFO,
> > > > + "virtio: using inorder mergeable buffer Rx path on
> > > port %u",
> > > > + eth_dev->data->port_id);
> > > > + eth_dev->rx_pkt_burst = &virtio_recv_mergeable_pkts_inorder;
> > > > } else if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) {
> > > > PMD_INIT_LOG(INFO,
> > > > "virtio: using mergeable buffer Rx path on port %u",
> > > > @@ -1335,6 +1340,10 @@ set_rxtx_funcs(struct rte_eth_dev *eth_dev)
> > > > PMD_INIT_LOG(INFO, "virtio: using simple Tx path on port %u",
> > > > eth_dev->data->port_id);
> > > > eth_dev->tx_pkt_burst = virtio_xmit_pkts_simple;
> > > > + } else if (hw->use_inorder_tx) {
> > > > + PMD_INIT_LOG(INFO, "virtio: using inorder Tx path on port %u",
> > > > + eth_dev->data->port_id);
> > > > + eth_dev->tx_pkt_burst = virtio_xmit_pkts_inorder;
> > > > } else {
> > > > PMD_INIT_LOG(INFO, "virtio: using standard Tx path on port %u",
> > > > eth_dev->data->port_id);
> > > > @@ -1871,24 +1880,24 @@ virtio_dev_configure(struct rte_eth_dev *dev)
> > > >
> > > > rte_spinlock_init(&hw->state_lock);
> > > >
> > > > - hw->use_simple_rx = 1;
> > > > - hw->use_simple_tx = 1;
> > > > -
> > > > #if defined RTE_ARCH_ARM64 || defined RTE_ARCH_ARM
> > > > if (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_NEON)) {
> > > > hw->use_simple_rx = 0;
> > > > hw->use_simple_tx = 0;
> > > > }
> > > > #endif
> > > > - if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) {
> > > > - hw->use_simple_rx = 0;
> > > > - hw->use_simple_tx = 0;
> > > > + if (vtpci_with_feature(hw, VIRTIO_F_IN_ORDER)) {
> > > > + if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) {
> > > > + hw->use_inorder_rx = 1;
> > > > + hw->use_inorder_tx = 1;
> > > > + } else {
> > > > + hw->use_simple_tx = 1;
> > > > + if (!(rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM |
> > > > + DEV_RX_OFFLOAD_TCP_CKSUM)))
> > > > + hw->use_simple_rx = 1;
> > > > + }
> > >
> > > It seems to be wrong.
> > > For example if IN_ORDER hasn't been negotiated, we might want to use the
> > > simple path if no rx offload have been requested by the application.
> > >
> > > It was the case before the patch if I'm not mistaken.
> >
> > Maxime,
> > IN_ORDER is the prerequisite for selection simple rx/tx path. So when IN_ORDER + mergeable off + no rx offload will chose simple rx path.
>
> Ok, I wonder in that case if I could just remove the simple Tx path in
> my series as it is not compliant with IN_ORDER.
> Tiwei, what's your take on this?
>
> Also, I wonder if it would make sense to backport the vhost patch that
> advertize IN_ORDER features to the LTS, as no functional changes, except
> that it prevents using "simple/inorder" path with dequeue zero copy,
> which is a good thing.
>
> Any thoughts?
IMO it's not right to choose the current simple Tx path
when IN_ORDER is negotiated. Because in split ring, IN_ORDER
requires the driver to use the descriptors in ring order
which is not the case in the current simple Tx path, and
things will go wrong when device wants to make full use
of the IN_ORDER feature.
Best regards,
Tiwei Bie
>
> > >
> > > Also, with ARM platform, we force not to use simple path, but in case
> > > IN_ORDER has been negotiated but not MRG_RXBUF, it gets re-enabled.
> >
> > Will move ARM force action behind normal selection, thus can satisfy ARM.
>
> I can change when applying.
>
> Thanks,
> Maxime
>
> > Thanks,
> > Marvin
> >
> > >
> > > > }
> > > >
> > > > - if (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM |
> > > > - DEV_RX_OFFLOAD_TCP_CKSUM))
> > > > - hw->use_simple_rx = 0;
> > > > -
> > > > return 0;
> > > > }
> > > >
> > > >
next prev parent reply other threads:[~2018-06-30 2:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 21:52 [dpdk-dev] [PATCH v3 00/11] support in-order feature Marvin Liu
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 01/11] vhost: advertise " Marvin Liu
2018-06-28 14:32 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 02/11] net/virtio: add in-order feature bit definition Marvin Liu
2018-06-28 14:33 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 03/11] net/virtio-user: add unsupported features mask Marvin Liu
2018-06-28 14:34 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 04/11] net/virtio-user: add mrg_rxbuf and in_order vdev parameters Marvin Liu
2018-06-28 14:43 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 05/11] net/virtio: free in-order descriptors before device start Marvin Liu
2018-06-28 14:45 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 06/11] net/virtio: extract common part for in-order functions Marvin Liu
2018-06-28 14:48 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 07/11] net/virtio: support in-order Rx and Tx Marvin Liu
2018-06-28 15:08 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 08/11] net/virtio: add in-order Rx/Tx into selection Marvin Liu
2018-06-28 15:16 ` Maxime Coquelin
2018-06-28 15:39 ` Liu, Yong
2018-06-29 8:04 ` Maxime Coquelin
2018-06-30 2:42 ` Tiwei Bie [this message]
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 09/11] net/virtio: advertise support in-order feature Marvin Liu
2018-06-28 15:16 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 10/11] doc: add mrg_rxbuf and in_order parameters for virtio device Marvin Liu
2018-06-28 15:17 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 11/11] doc: add in-order funciton " Marvin Liu
2018-06-28 15:17 ` Maxime Coquelin
2018-06-29 13:10 ` [dpdk-dev] [PATCH v3 00/11] support in-order feature Maxime Coquelin
2018-06-30 16:07 ` Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180630024248.GA5834@debian \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=yong.liu@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).