From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org,
mst@redhat.com, jasowang@redhat.com, wexu@redhat.com
Subject: Re: [dpdk-dev] [PATCH v8 01/15] vhost: add virtio packed virtqueue defines
Date: Fri, 6 Jul 2018 10:52:50 +0800 [thread overview]
Message-ID: <20180706025249.GA13855@debian> (raw)
In-Reply-To: <20180705210741.17974-2-maxime.coquelin@redhat.com>
On Thu, Jul 05, 2018 at 11:07:27PM +0200, Maxime Coquelin wrote:
> From: Jens Freimann <jfreimann@redhat.com>
>
> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
> ---
> lib/librte_vhost/vhost.h | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> index 79e3117d2..4fc804bd8 100644
> --- a/lib/librte_vhost/vhost.h
> +++ b/lib/librte_vhost/vhost.h
> @@ -192,6 +192,26 @@ struct vhost_msg {
> #define VIRTIO_F_VERSION_1 32
> #endif
>
> +/* Declare packed ring related bits for older kernels */
> +#ifndef VIRTIO_F_RING_PACKED
> +
> +#define VIRTIO_F_RING_PACKED 34
> +
> +#define VRING_DESC_F_NEXT 1
> +#define VRING_DESC_F_WRITE 2
> +#define VRING_DESC_F_INDIRECT 4
> +
> +#define VRING_DESC_F_AVAIL (1ULL << 7)
> +#define VRING_DESC_F_USED (1ULL << 15)
> +
> +struct vring_desc_packed {
Maybe vring_packed_desc will be more consistent with
vring_packed_desc_event and vring_packed. Jason also
planned to change the name to vring_packed_desc [1].
[1] https://lkml.org/lkml/2018/7/4/36
Best regards,
Tiwei Bie
> + uint64_t addr;
> + uint32_t len;
> + uint16_t id;
> + uint16_t flags;
> +};
> +#endif
> +
> /*
> * Available and used descs are in same order
> */
> --
> 2.14.4
>
next prev parent reply other threads:[~2018-07-06 2:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 21:07 [dpdk-dev] [PATCH v8 00/15] Vhost: add support to packed ring layout Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 01/15] vhost: add virtio packed virtqueue defines Maxime Coquelin
2018-07-06 2:52 ` Tiwei Bie [this message]
2018-07-06 6:34 ` Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 02/15] vhost: add helpers for packed virtqueues Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 03/15] vhost: vring address setup for packed queues Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 04/15] vhost: clear shadow used table index at flush time Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 05/15] vhost: make indirect desc table copy desc type agnostic Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 06/15] vhost: clear batch copy index at copy time Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 07/15] vhost: extract split ring handling from Rx and Tx functions Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 08/15] vhost: append shadow used ring function names with split Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 09/15] vhost: add shadow used ring support for packed rings Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 10/15] vhost: create descriptor mapping function Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 11/15] vhost: add vector filling support for packed ring Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 12/15] vhost: add Rx " Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 13/15] vhost: add Tx " Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 14/15] vhost: add notification " Maxime Coquelin
2018-07-05 21:07 ` [dpdk-dev] [PATCH v8 15/15] vhost: advertize packed ring layout support Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706025249.GA13855@debian \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=jasowang@redhat.com \
--cc=jfreimann@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=wexu@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).