DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: shally.verma@caviumnetworks.com, ashish.gupta@caviumnetworks.com,
	fiona.trahe@intel.com, lee.daly@intel.com
Cc: dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: [dpdk-dev] [PATCH v4 4/4] compressdev: add huffman encoding flags
Date: Fri,  6 Jul 2018 03:54:30 +0100	[thread overview]
Message-ID: <20180706025430.21342-4-pablo.de.lara.guarch@intel.com> (raw)
In-Reply-To: <20180706025430.21342-1-pablo.de.lara.guarch@intel.com>

Added Huffman fixed and dynamic encoding feature flags,
so an application can query if a device supports
these two types, when performing DEFLATE compression.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---

v4/v3:
- No change

v2:
- Fixed typo

 drivers/compress/isal/isal_compress_pmd_ops.c |  4 +++-
 lib/librte_compressdev/rte_comp.c             |  4 ++++
 lib/librte_compressdev/rte_comp.h             |  4 ++++
 test/test/test_compressdev.c                  | 16 ++++++++++++++++
 4 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c b/drivers/compress/isal/isal_compress_pmd_ops.c
index 970a0413b..585f22802 100644
--- a/drivers/compress/isal/isal_compress_pmd_ops.c
+++ b/drivers/compress/isal/isal_compress_pmd_ops.c
@@ -12,7 +12,9 @@
 static const struct rte_compressdev_capabilities isal_pmd_capabilities[] = {
 	{
 		.algo = RTE_COMP_ALGO_DEFLATE,
-		.comp_feature_flags =	RTE_COMP_FF_SHAREABLE_PRIV_XFORM,
+		.comp_feature_flags =	RTE_COMP_FF_SHAREABLE_PRIV_XFORM |
+					RTE_COMP_FF_HUFFMAN_FIXED |
+					RTE_COMP_FF_HUFFMAN_DYNAMIC,
 		.window_size = {
 			.min = 15,
 			.max = 15,
diff --git a/lib/librte_compressdev/rte_comp.c b/lib/librte_compressdev/rte_comp.c
index 97ea0d922..98ad0cfd9 100644
--- a/lib/librte_compressdev/rte_comp.c
+++ b/lib/librte_compressdev/rte_comp.c
@@ -36,6 +36,10 @@ rte_comp_get_feature_name(uint64_t flag)
 		return "SHA2_SHA256_HASH";
 	case RTE_COMP_FF_SHAREABLE_PRIV_XFORM:
 		return "SHAREABLE_PRIV_XFORM";
+	case RTE_COMP_FF_HUFFMAN_FIXED:
+		return "HUFFMAN_FIXED";
+	case RTE_COMP_FF_HUFFMAN_DYNAMIC:
+		return "HUFFMAN_DYNAMIC";
 	default:
 		return NULL;
 	}
diff --git a/lib/librte_compressdev/rte_comp.h b/lib/librte_compressdev/rte_comp.h
index 274b5eadf..1f66945ee 100644
--- a/lib/librte_compressdev/rte_comp.h
+++ b/lib/librte_compressdev/rte_comp.h
@@ -63,6 +63,10 @@ extern "C" {
  * to create as many priv_xforms as it expects to have stateless
  * operations in-flight.
  */
+#define RTE_COMP_FF_HUFFMAN_FIXED		(1ULL << 13)
+/**< Fixed huffman encoding is supported */
+#define RTE_COMP_FF_HUFFMAN_DYNAMIC		(1ULL << 14)
+/**< Dynamic huffman encoding is supported */
 
 /** Status of comp operation */
 enum rte_comp_op_status {
diff --git a/test/test/test_compressdev.c b/test/test/test_compressdev.c
index 640942bac..f960963a4 100644
--- a/test/test/test_compressdev.c
+++ b/test/test/test_compressdev.c
@@ -846,6 +846,14 @@ test_compressdev_deflate_stateless_fixed(void)
 	const char *test_buffer;
 	uint16_t i;
 	int ret;
+	const struct rte_compressdev_capabilities *capab;
+
+	capab = rte_compressdev_capability_get(0, RTE_COMP_ALGO_DEFLATE);
+	TEST_ASSERT(capab != NULL, "Failed to retrieve device capabilities");
+
+	if ((capab->comp_feature_flags & RTE_COMP_FF_HUFFMAN_FIXED) == 0)
+		return -ENOTSUP;
+
 	struct rte_comp_xform *compress_xform =
 			rte_malloc(NULL, sizeof(struct rte_comp_xform), 0);
 
@@ -905,6 +913,14 @@ test_compressdev_deflate_stateless_dynamic(void)
 	struct rte_comp_xform *compress_xform =
 			rte_malloc(NULL, sizeof(struct rte_comp_xform), 0);
 
+	const struct rte_compressdev_capabilities *capab;
+
+	capab = rte_compressdev_capability_get(0, RTE_COMP_ALGO_DEFLATE);
+	TEST_ASSERT(capab != NULL, "Failed to retrieve device capabilities");
+
+	if ((capab->comp_feature_flags & RTE_COMP_FF_HUFFMAN_DYNAMIC) == 0)
+		return -ENOTSUP;
+
 	if (compress_xform == NULL) {
 		RTE_LOG(ERR, USER1,
 			"Compress xform could not be created\n");
-- 
2.14.4

  parent reply	other threads:[~2018-07-06 11:00 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27  5:50 [dpdk-dev] [PATCH 1/2] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-06-27  5:50 ` [dpdk-dev] [PATCH 2/2] compressdev: add huffman encoding flags Pablo de Lara
2018-06-27 15:22   ` Trahe, Fiona
2018-06-27 15:36     ` De Lara Guarch, Pablo
2018-06-27 17:35       ` Trahe, Fiona
2018-06-28 10:00   ` Daly, Lee
2018-06-27 12:16 ` [dpdk-dev] [PATCH v2 1/2] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-06-27 12:16   ` [dpdk-dev] [PATCH v2 2/2] compressdev: add huffman encoding flags Pablo de Lara
2018-06-28  7:49     ` Trahe, Fiona
2018-06-28  7:48   ` [dpdk-dev] [PATCH v2 1/2] compressdev: replace mbuf scatter gather flag Trahe, Fiona
2018-06-29 10:08   ` Trahe, Fiona
2018-06-27 15:14 ` [dpdk-dev] [PATCH " Trahe, Fiona
2018-06-27 15:33   ` De Lara Guarch, Pablo
2018-07-04 14:10 ` [dpdk-dev] [PATCH v3 1/4] doc: cleanup ISA-L PMD feature matrix Pablo de Lara
2018-07-04 14:10   ` [dpdk-dev] [PATCH v3 2/4] doc: rename compress feature flag Pablo de Lara
2018-07-05  2:41     ` Verma, Shally
2018-07-05 11:03       ` De Lara Guarch, Pablo
2018-07-05  8:07     ` Trahe, Fiona
2018-07-04 14:10   ` [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-07-05  8:38     ` Verma, Shally
2018-07-05 11:05       ` De Lara Guarch, Pablo
2018-07-05 11:12         ` Verma, Shally
2018-07-05 11:25           ` De Lara Guarch, Pablo
2018-07-05 11:58             ` Verma, Shally
2018-07-06  8:40               ` De Lara Guarch, Pablo
2018-07-06  8:53                 ` Verma, Shally
2018-07-06  8:59                   ` De Lara Guarch, Pablo
2018-07-04 14:10   ` [dpdk-dev] [PATCH v3 4/4] compressdev: add huffman encoding flags Pablo de Lara
2018-07-05  8:14     ` Verma, Shally
2018-07-05 11:21       ` De Lara Guarch, Pablo
2018-07-05  8:10   ` [dpdk-dev] [PATCH v3 1/4] doc: cleanup ISA-L PMD feature matrix Daly, Lee
2018-07-06  2:54 ` [dpdk-dev] [PATCH v4 " Pablo de Lara
2018-07-06  2:54   ` [dpdk-dev] [PATCH v4 2/4] doc: rename compress feature flag Pablo de Lara
2018-07-06 12:17     ` Verma, Shally
2018-07-06  2:54   ` [dpdk-dev] [PATCH v4 3/4] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-07-06 12:33     ` Verma, Shally
2018-07-06  2:54   ` Pablo de Lara [this message]
2018-07-06  5:27 ` [dpdk-dev] [PATCH v5 1/4] doc: cleanup ISA-L PMD feature matrix Pablo de Lara
2018-07-06  5:27   ` [dpdk-dev] [PATCH v5 2/4] doc: rename compress feature flag Pablo de Lara
2018-07-06  5:28   ` [dpdk-dev] [PATCH v5 3/4] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-07-07  6:34     ` Verma, Shally
2018-07-09  8:07       ` De Lara Guarch, Pablo
2018-07-06  5:28   ` [dpdk-dev] [PATCH v5 4/4] compressdev: add huffman encoding flags Pablo de Lara
2018-07-07  6:36     ` Verma, Shally
2018-07-09  8:11   ` [dpdk-dev] [PATCH v5 1/4] doc: cleanup ISA-L PMD feature matrix De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180706025430.21342-4-pablo.de.lara.guarch@intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=ashish.gupta@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=lee.daly@intel.com \
    --cc=shally.verma@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).