DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org,
	mst@redhat.com, jasowang@redhat.com, wexu@redhat.com,
	Yuanhan Liu <yuanhan.liu@linux.intel.com>,
	Jens Freimann <jfreiman@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v9 03/15] vhost: vring address setup for packed queues
Date: Mon, 9 Jul 2018 10:09:32 +0800	[thread overview]
Message-ID: <20180709020932.GA16302@debian> (raw)
In-Reply-To: <20180706070722.2043-4-maxime.coquelin@redhat.com>

On Fri, Jul 06, 2018 at 09:07:10AM +0200, Maxime Coquelin wrote:
[...]
> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> index bea6a0428..dca43ff00 100644
> --- a/lib/librte_vhost/vhost_user.c
> +++ b/lib/librte_vhost/vhost_user.c
> @@ -467,6 +467,27 @@ translate_ring_addresses(struct virtio_net *dev, int vq_index)
>  	struct vhost_vring_addr *addr = &vq->ring_addrs;
>  	uint64_t len;
>  
> +	if (vq_is_packed(dev)) {
> +		len = sizeof(struct vring_packed_desc) * vq->size;
> +		vq->desc_packed = (struct vring_packed_desc *) ring_addr_to_vva

FYI, above code will cause below build error on 32bit platform:

/tmp/dpdk-build/lib/librte_vhost/vhost_user.c: In function ‘translate_ring_addresses’:
/tmp/dpdk-build/lib/librte_vhost/vhost_user.c:472:21: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
   vq->desc_packed = (struct vring_packed_desc *) ring_addr_to_vva
                     ^

I'll fix it while applying.

  reply	other threads:[~2018-07-09  2:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06  7:07 [dpdk-dev] [PATCH v9 00/15] Vhost: add support to packed ring layout Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 01/15] vhost: add virtio packed virtqueue defines Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 02/15] vhost: add helpers for packed virtqueues Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 03/15] vhost: vring address setup for packed queues Maxime Coquelin
2018-07-09  2:09   ` Tiwei Bie [this message]
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 04/15] vhost: clear shadow used table index at flush time Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 05/15] vhost: make indirect desc table copy desc type agnostic Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 06/15] vhost: clear batch copy index at copy time Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 07/15] vhost: extract split ring handling from Rx and Tx functions Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 08/15] vhost: append shadow used ring function names with split Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 09/15] vhost: add shadow used ring support for packed rings Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 10/15] vhost: create descriptor mapping function Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 11/15] vhost: add vector filling support for packed ring Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 12/15] vhost: add Rx " Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 13/15] vhost: add Tx " Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 14/15] vhost: add notification " Maxime Coquelin
2018-07-06  7:07 ` [dpdk-dev] [PATCH v9 15/15] vhost: advertize packed ring layout support Maxime Coquelin
2018-07-09  7:11   ` Tiwei Bie
2018-07-09  1:28 ` [dpdk-dev] [PATCH v9 00/15] Vhost: add support to packed ring layout Tiwei Bie
2018-07-09  7:04 ` Tiwei Bie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180709020932.GA16302@debian \
    --to=tiwei.bie@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasowang@redhat.com \
    --cc=jfreiman@redhat.com \
    --cc=jfreimann@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=wexu@redhat.com \
    --cc=yuanhan.liu@linux.intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).