From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org,
mst@redhat.com, jasowang@redhat.com, wexu@redhat.com
Subject: Re: [dpdk-dev] [PATCH v9 15/15] vhost: advertize packed ring layout support
Date: Mon, 9 Jul 2018 15:11:10 +0800 [thread overview]
Message-ID: <20180709071109.GB5900@debian> (raw)
In-Reply-To: <20180706070722.2043-16-maxime.coquelin@redhat.com>
On Fri, Jul 06, 2018 at 09:07:22AM +0200, Maxime Coquelin wrote:
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> lib/librte_vhost/vhost.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> index 760a09c0d..9b0ebb754 100644
> --- a/lib/librte_vhost/vhost.h
> +++ b/lib/librte_vhost/vhost.h
> @@ -275,7 +275,8 @@ struct vring_packed_desc_event {
> (1ULL << VIRTIO_RING_F_EVENT_IDX) | \
> (1ULL << VIRTIO_NET_F_MTU) | \
> (1ULL << VIRTIO_F_IN_ORDER) | \
> - (1ULL << VIRTIO_F_IOMMU_PLATFORM))
> + (1ULL << VIRTIO_F_IOMMU_PLATFORM) | \
> + (1ULL << VIRTIO_F_RING_PACKED))
>
>
> struct guest_page {
> --
> 2.14.4
>
I didn't apply this patch, because the packed ring
support isn't complete, e.g. when doing live migration,
the wrap counter isn't synced. We can advertise this
feature bit when it's fully supported.
next prev parent reply other threads:[~2018-07-09 7:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 7:07 [dpdk-dev] [PATCH v9 00/15] Vhost: add support to packed ring layout Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 01/15] vhost: add virtio packed virtqueue defines Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 02/15] vhost: add helpers for packed virtqueues Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 03/15] vhost: vring address setup for packed queues Maxime Coquelin
2018-07-09 2:09 ` Tiwei Bie
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 04/15] vhost: clear shadow used table index at flush time Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 05/15] vhost: make indirect desc table copy desc type agnostic Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 06/15] vhost: clear batch copy index at copy time Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 07/15] vhost: extract split ring handling from Rx and Tx functions Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 08/15] vhost: append shadow used ring function names with split Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 09/15] vhost: add shadow used ring support for packed rings Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 10/15] vhost: create descriptor mapping function Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 11/15] vhost: add vector filling support for packed ring Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 12/15] vhost: add Rx " Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 13/15] vhost: add Tx " Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 14/15] vhost: add notification " Maxime Coquelin
2018-07-06 7:07 ` [dpdk-dev] [PATCH v9 15/15] vhost: advertize packed ring layout support Maxime Coquelin
2018-07-09 7:11 ` Tiwei Bie [this message]
2018-07-09 1:28 ` [dpdk-dev] [PATCH v9 00/15] Vhost: add support to packed ring layout Tiwei Bie
2018-07-09 7:04 ` Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709071109.GB5900@debian \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=jasowang@redhat.com \
--cc=jfreimann@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=wexu@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).