From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomasm@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix missing function in map file
Date: Fri, 13 Jul 2018 11:09:24 +0200 [thread overview]
Message-ID: <20180713090924.oodkzikcxxiwcngg@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8977F8F9D02@IRSMSX107.ger.corp.intel.com>
Hi Pablo,
On Fri, Jul 13, 2018 at 08:52:07AM +0000, De Lara Guarch, Pablo wrote:
> Hi Nelio,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nelio Laranjeiro
> > Sent: Friday, July 13, 2018 9:25 AM
> > To: dev@dpdk.org; Thomas Monjalon <thomasm@mellanox.com>
> > Subject: [dpdk-dev] [PATCH] ethdev: fix missing function in map file
> >
> > Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows")
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > ---
> > lib/librte_ethdev/rte_ethdev_version.map | 1 +
> > lib/librte_ethdev/rte_flow_driver.h | 2 +-
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_ethdev/rte_ethdev_version.map
> > b/lib/librte_ethdev/rte_ethdev_version.map
> > index 9a0d12d41..0af8731b6 100644
> > --- a/lib/librte_ethdev/rte_ethdev_version.map
> > +++ b/lib/librte_ethdev/rte_ethdev_version.map
> > @@ -251,4 +251,5 @@ EXPERIMENTAL {
> > rte_mtr_policer_actions_update;
> > rte_mtr_stats_read;
> > rte_mtr_stats_update;
> > + rte_flow_expand_rss;
>
> This list is in alphabetical order.
> > };
> > diff --git a/lib/librte_ethdev/rte_flow_driver.h
> > b/lib/librte_ethdev/rte_flow_driver.h
> > index ca675f6d3..141d4acac 100644
> > --- a/lib/librte_ethdev/rte_flow_driver.h
> > +++ b/lib/librte_ethdev/rte_flow_driver.h
> > @@ -169,7 +169,7 @@ struct rte_flow_expand_rss {
> > *
> > * -E2BIG: graph-depth @p graph is too deep.
> > */
> > -int
> > +int __rte_experimental
>
> The implementation in the .c file should also have the experimental tag.
>
> > rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,
> > const struct rte_flow_item *pattern, uint64_t types,
> > const struct rte_flow_expand_node graph[],
> > --
Will fix both point in a v2.
Thanks,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-07-13 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 8:24 Nelio Laranjeiro
2018-07-13 8:52 ` De Lara Guarch, Pablo
2018-07-13 9:09 ` Nélio Laranjeiro [this message]
2018-07-13 9:11 ` Nelio Laranjeiro
2018-07-13 13:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713090924.oodkzikcxxiwcngg@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomasm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).