From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: thomas@monjalon.net, anatoly.burakov@intel.com, dev@dpdk.org,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 1/4] eal: fix hotplug add and hotplug remove
Date: Wed, 18 Jul 2018 15:10:26 +0200 [thread overview]
Message-ID: <20180718131026.3qfymf45meglfuea@bidouze.vm.6wind.com> (raw)
In-Reply-To: <20180712140144.18146-2-qi.z.zhang@intel.com>
Hi Qi,
On Thu, Jul 12, 2018 at 10:01:41PM +0800, Qi Zhang wrote:
> If hotplug add an already plugged PCI device, it will
> cause rte_pci_device->device.name be corrupted due to unexpected
> rte_devargs_remove. Also if try to hotplug remove an already
> unplugged device, it will cause segment fault due to unexpected
> bus->unplug on a rte_device whose driver is NULL.
> The patch fix these issues.
>
> Fixes: 7e8b26650146 ("eal: fix hotplug add / remove")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
I think we should consolidate this API at some point, maybe list the
possible error values as a part of it and remove the experimental tag.
In any case, the fix seems correct, thanks,
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
--
Gaëtan Rivet
6WIND
next prev parent reply other threads:[~2018-07-18 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180712140144.18146-1-qi.z.zhang@intel.com>
2018-07-12 14:01 ` Qi Zhang
2018-07-18 13:10 ` Gaëtan Rivet [this message]
2018-07-12 14:01 ` [dpdk-stable] [PATCH 2/4] bus/pci: fix PCI address compare Qi Zhang
2018-07-18 13:11 ` Gaëtan Rivet
2018-07-12 14:01 ` [dpdk-stable] [PATCH 4/4] vfio: remove uneccessary IPC for group fd clear Qi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718131026.3qfymf45meglfuea@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).