From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start and stop in Rx adapter
Date: Tue, 24 Jul 2018 21:08:05 +0530 [thread overview]
Message-ID: <20180724153804.GB11073@jerin> (raw)
In-Reply-To: <20180719114747.25430-1-pbhagavatula@caviumnetworks.com>
-----Original Message-----
> Date: Thu, 19 Jul 2018 17:17:47 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: jerin.jacob@caviumnetworks.com
> Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start
> and stop in Rx adapter
> X-Mailer: git-send-email 2.18.0
>
> Modifying port state is not necessary when starting/stopping Rx adapter
> as it is same as starting/stopping ethdev.
>
> Fixes: 45a914c5bd71 ("event/octeontx: support event Rx adapter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> drivers/event/octeontx/ssovf_evdev.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c
> index 2df70b52a..f98296f18 100644
> --- a/drivers/event/octeontx/ssovf_evdev.c
> +++ b/drivers/event/octeontx/ssovf_evdev.c
> @@ -476,14 +476,9 @@ static int
> ssovf_eth_rx_adapter_start(const struct rte_eventdev *dev,
> const struct rte_eth_dev *eth_dev)
> {
> - int ret;
> - const struct octeontx_nic *nic = eth_dev->data->dev_private;
> RTE_SET_USED(dev);
> + RTE_SET_USED(eth_dev);
>
> - ret = strncmp(eth_dev->data->name, "eth_octeontx", 12);
> - if (ret)
> - return 0;
> - octeontx_pki_port_start(nic->port_id);
> return 0;
> }
>
> @@ -492,14 +487,9 @@ static int
> ssovf_eth_rx_adapter_stop(const struct rte_eventdev *dev,
> const struct rte_eth_dev *eth_dev)
> {
> - int ret;
> - const struct octeontx_nic *nic = eth_dev->data->dev_private;
> RTE_SET_USED(dev);
> + RTE_SET_USED(eth_dev);
>
> - ret = strncmp(eth_dev->data->name, "eth_octeontx", 12);
> - if (ret)
> - return 0;
> - octeontx_pki_port_stop(nic->port_id);
> return 0;
> }
>
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-07-24 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 11:47 Pavan Nikhilesh
2018-07-24 15:38 ` Jerin Jacob [this message]
2018-07-25 13:14 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724153804.GB11073@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=pbhagavatula@caviumnetworks.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).