From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] app/eventdev: use proper teardown sequence
Date: Tue, 24 Jul 2018 21:09:52 +0530 [thread overview]
Message-ID: <20180724153950.GD11073@jerin> (raw)
In-Reply-To: <20180724121450.9969-1-pbhagavatula@caviumnetworks.com>
-----Original Message-----
> Date: Tue, 24 Jul 2018 17:44:50 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: jerin.jacob@caviumnetworks.com
> Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH v4] app/eventdev: use proper teardown sequence
> X-Mailer: git-send-email 2.18.0
>
> Use proper teardown sequence when SIGINT is caught to prevent
> eventdev from going into undefined state.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> v4 Changes:
> - Check opts before closing ethdev.
>
> v3 Changes:
> - Segregate ethdev_stop and close to prevent possible SEGFAULT.
> - handle early shutdown.
>
> v2 Changes:
> - Only stopping the ethdev(producer) is sufficient.(Jerin)
>
> app/test-eventdev/evt_main.c | 42 +++++++++++++++---------
> app/test-eventdev/test_perf_common.c | 1 -
> app/test-eventdev/test_pipeline_common.c | 1 -
> 3 files changed, 27 insertions(+), 17 deletions(-)
>
> diff --git a/app/test-eventdev/evt_main.c b/app/test-eventdev/evt_main.c
> index 57bb94570..a8d304bab 100644
> --- a/app/test-eventdev/evt_main.c
> +++ b/app/test-eventdev/evt_main.c
> @@ -20,29 +20,41 @@ struct evt_test *test;
> static void
> signal_handler(int signum)
> {
> - if (signum == SIGINT || signum == SIGTERM) {
> + int i;
> + static uint8_t once;
> +
> + if ((signum == SIGINT || signum == SIGTERM) && !once) {
> + once = true;
> printf("\nSignal %d received, preparing to exit...\n",
> signum);
> - /* request all lcores to exit from the main loop */
> - *(int *)test->test_priv = true;
> - rte_wmb();
>
> - rte_eal_mp_wait_lcore();
> + if (test != NULL) {
> + /* request all lcores to exit from the main loop */
> + *(int *)test->test_priv = true;
> + rte_wmb();
> +
> + if (test->ops.ethdev_destroy)
> + test->ops.ethdev_destroy(test, &opt);
>
> - if (test->ops.test_result)
> - test->ops.test_result(test, &opt);
> + rte_eal_mp_wait_lcore();
>
> - if (test->ops.eventdev_destroy)
> - test->ops.eventdev_destroy(test, &opt);
> + if (test->ops.test_result)
> + test->ops.test_result(test, &opt);
>
> - if (test->ops.ethdev_destroy)
> - test->ops.ethdev_destroy(test, &opt);
> + if (opt.prod_type == EVT_PROD_TYPE_ETH_RX_ADPTR) {
> + RTE_ETH_FOREACH_DEV(i)
> + rte_eth_dev_close(i);
> + }
>
> - if (test->ops.mempool_destroy)
> - test->ops.mempool_destroy(test, &opt);
> + if (test->ops.eventdev_destroy)
> + test->ops.eventdev_destroy(test, &opt);
>
> - if (test->ops.test_destroy)
> - test->ops.test_destroy(test, &opt);
> + if (test->ops.mempool_destroy)
> + test->ops.mempool_destroy(test, &opt);
> +
> + if (test->ops.test_destroy)
> + test->ops.test_destroy(test, &opt);
> + }
>
> /* exit with the expected status */
> signal(signum, SIG_DFL);
> diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
> index d00f91802..6d39f98e0 100644
> --- a/app/test-eventdev/test_perf_common.c
> +++ b/app/test-eventdev/test_perf_common.c
> @@ -743,7 +743,6 @@ void perf_ethdev_destroy(struct evt_test *test, struct evt_options *opt)
> RTE_ETH_FOREACH_DEV(i) {
> rte_event_eth_rx_adapter_stop(i);
> rte_eth_dev_stop(i);
> - rte_eth_dev_close(i);
> }
> }
> }
> diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
> index 719518ff3..96e7c9882 100644
> --- a/app/test-eventdev/test_pipeline_common.c
> +++ b/app/test-eventdev/test_pipeline_common.c
> @@ -467,7 +467,6 @@ pipeline_ethdev_destroy(struct evt_test *test, struct evt_options *opt)
> RTE_ETH_FOREACH_DEV(i) {
> rte_event_eth_rx_adapter_stop(i);
> rte_eth_dev_stop(i);
> - rte_eth_dev_close(i);
> }
> }
>
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-07-24 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 14:33 [dpdk-dev] [PATCH] " Pavan Nikhilesh
2018-07-18 17:36 ` Jerin Jacob
2018-07-19 11:41 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh
2018-07-24 11:01 ` [dpdk-dev] [PATCH v3] " Pavan Nikhilesh
2018-07-24 12:14 ` [dpdk-dev] [PATCH v4] " Pavan Nikhilesh
2018-07-24 15:39 ` Jerin Jacob [this message]
2018-07-25 13:12 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724153950.GD11073@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).