From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Takeshi Yoshimura <t.yoshimura8869@gmail.com>,
dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5] vfio: fix workaround of BAR mapping
Date: Sun, 29 Jul 2018 14:14:59 +0530 [thread overview]
Message-ID: <20180729084457.GA8905@jerin> (raw)
In-Reply-To: <30652783.zuAJVELDdt@xps>
-----Original Message-----
> Date: Thu, 26 Jul 2018 11:35:43 +0200
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Takeshi Yoshimura <t.yoshimura8869@gmail.com>
> Cc: dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v5] vfio: fix workaround of BAR mapping
>
>
> 20/07/2018 10:13, Takeshi Yoshimura:
> > Currently, VFIO will try to map around MSI-X table in the BARs. When
> > MSI-X table (page-aligned) size is equal to (page-aligned) size of BAR,
> > VFIO will just skip the BAR.
> >
> > Recent kernel versions will allow VFIO to map the entire BAR containing
> > MSI-X tables (*), so instead of trying to map around the MSI-X vector
> > or skipping the BAR entirely if it's not possible, we can now try
> > mapping the entire BAR first. If mapping the entire BAR doesn't
> > succeed, fall back to the old behavior of mapping around MSI-X table or
> > skipping the BAR.
> >
> > (*): "vfio-pci: Allow mapping MSIX BAR",
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
> > commit/?id=a32295c612c57990d17fb0f41e7134394b2f35f6
> >
> > Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables")
> >
> > Signed-off-by: Takeshi Yoshimura <t.yoshimura8869@gmail.com>
> > Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
This change set breaks thunderx/octeontx platform with following error.(Tested with 4.9.0 kernel)
EAL: probe driver: 177d:a034 net_thunderx
EAL: using IOMMU type 1 (Type 1)
EAL: pci_map_resource(): cannot mmap(44, 0xffff60200000, 0x200000, 0x40000000000): Invalid argument (0xffffffffffffffff)
EAL: PCI device 0001:01:00.2 on NUMA socket 0
EAL: probe driver: 177d:a034 net_thunderx
EAL: pci_map_resource(): cannot mmap(47, 0xffff60600000, 0x200000, 0x40000000000): Invalid argument (0xffffffffffffffff)
According Linux kernel change, user space application suppose to use VFIO_REGION_INFO_CAP_MSIX_MAPPABLE
capability to detect this feature to work < 4.15 kernel. Right? if so, Why we
are doing this retry based logic?
>
> Applied, thanks
>
>
>
next prev parent reply other threads:[~2018-07-29 8:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 2:44 [dpdk-dev] [PATCH] vfio: fix workaround of BAR0 mapping Takeshi Yoshimura
2018-07-12 3:08 ` [dpdk-dev] [PATCH v2] " Takeshi Yoshimura
2018-07-12 9:10 ` Burakov, Anatoly
2018-07-13 10:11 ` [dpdk-dev] [PATCH v3] " Takeshi Yoshimura
2018-07-13 11:00 ` Burakov, Anatoly
2018-07-13 11:08 ` Burakov, Anatoly
2018-07-17 8:21 ` Takeshi Yoshimura
2018-07-17 8:22 ` [dpdk-dev] [PATCH v4] " Takeshi Yoshimura
2018-07-17 10:08 ` Burakov, Anatoly
2018-07-20 8:13 ` [dpdk-dev] [PATCH v5] vfio: fix workaround of BAR mapping Takeshi Yoshimura
2018-07-26 9:35 ` Thomas Monjalon
2018-07-29 8:44 ` Jerin Jacob [this message]
2018-07-30 8:51 ` Burakov, Anatoly
2018-07-30 10:03 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180729084457.GA8905@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=t.yoshimura8869@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).