DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: Marvin Liu <yong.liu@intel.com>
Cc: marko.kovacevic@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] doc: add note for builtin-net-driver option
Date: Tue, 31 Jul 2018 15:27:10 +0800	[thread overview]
Message-ID: <20180731072710.GA77155@debian.sh.intel.com> (raw)
In-Reply-To: <20180726142738.58543-1-yong.liu@intel.com>

On Thu, Jul 26, 2018 at 10:27:38PM +0800, Marvin Liu wrote:
> Option builtin-net-driver is used to demonstrate how to implement
> vhost-user driver based on vhost lib APIs. Unfortunately, very simple
> vhost driver in vhost sample is incompatible with QEMU as protocol
> feature not supported.
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> ---
> v2:
> * Updated descriptions.
> ---
> diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vhost.rst
> index 9112e7897..396d83211 100644
> --- a/doc/guides/sample_app_ug/vhost.rst
> +++ b/doc/guides/sample_app_ug/vhost.rst
> @@ -158,6 +158,11 @@ when disabling VLAN strip. Such feature, which heavily depends on hardware,
>  should be removed from this example to reduce confusion. Now, VLAN strip is
>  enabled and cannot be disabled.
>  
> +**--builtin-net-driver**
> +Very simple enqueue and dequeue function will be used when this option is
> +given. It can demonstrate how to construct vhost-user driver with vhost lib
> +APIs. It is disabled by default.

Maybe something like:

A very simple vhost-user net driver which demonstrates how to
use the generic vhost APIs will be used when this option is
given. It is disabled by default.

> +
>  Common Issues
>  -------------
>  
> @@ -192,3 +197,8 @@ Common Issues
>    according to the NIC's property. ::
>  
>        make EXTRA_CFLAGS="-DMAX_QUEUES=320"
> +
> +* Option "builtin-net-driver" is incompatible with QEMU.

Better to remove above '.'

> +
> +  QEMU vhost net device start will fail if protocol feature is not
> +  negotiated. DPDK virtio-user can be the replacement of QEMU.
> -- 
> 2.17.0
> 

  reply	other threads:[~2018-07-31  7:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 17:12 [dpdk-dev] [PATCH] " Marvin Liu
2018-07-26 14:27 ` [dpdk-dev] [PATCH v2] " Marvin Liu
2018-07-31  7:27   ` Tiwei Bie [this message]
2018-07-31 16:00   ` [dpdk-dev] [PATCH v3] " Marvin Liu
2018-08-07 13:52     ` Mcnamara, John
2018-08-09 19:21       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180731072710.GA77155@debian.sh.intel.com \
    --to=tiwei.bie@intel.com \
    --cc=dev@dpdk.org \
    --cc=marko.kovacevic@intel.com \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).