From: Stephen Hemminger <stephen@networkplumber.org>
To: Gavin Hu <gavin.hu@arm.com>
Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] devtools: trap SIGINT is not recognizable to dash
Date: Fri, 3 Aug 2018 15:17:15 -0700 [thread overview]
Message-ID: <20180803151715.4197d43d@xeon-e3> (raw)
In-Reply-To: <20180801052257.14869-1-gavin.hu@arm.com>
On Wed, 1 Aug 2018 13:22:57 +0800
Gavin Hu <gavin.hu@arm.com> wrote:
> When running checkpatch.sh, it generates the following error
> on some linux distributions(like Debian) with Dash as the
> default shell interpreter.
> trap: SIGINT: bad trap
>
> The fix is to replace SIGINT with INT signal, it works for
> both bash and dash.
>
> Fixes: 4bec48184e ("devtools: add checks for ABI symbol addition")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@amr.com>
> ---
> devtools/checkpatches.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index 2509269df..ba795ad1d 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -29,7 +29,7 @@ clean_tmp_files() {
> fi
> }
>
> -trap "clean_tmp_files" SIGINT
> +trap "clean_tmp_files" INT
>
> print_usage () {
> cat <<- END_OF_HELP
This patch alone is not sufficient to make checkpatch run successfully
./devtools/checkpatches.sh: 52: read: Illegal option -d
It looks like the -d flag to read is also a bash extension.
I recommend changing both checkpatches.sh and check-symbol-changes to have #!/bin/bash
next prev parent reply other threads:[~2018-08-03 22:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 5:22 [dpdk-stable] " Gavin Hu
2018-08-01 10:40 ` Mcnamara, John
2018-08-01 13:09 ` Varghese, Vipin
2018-08-01 14:37 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-08-03 22:17 ` Stephen Hemminger [this message]
2018-08-04 6:42 ` Gavin Hu
2018-08-06 17:12 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803151715.4197d43d@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).