From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Matan Azrad <matan@mellanox.com>
Cc: Keith Wiles <keith.wiles@intel.com>,
Ophir Munk <ophirmu@mellanox.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] net/tap: fix zeroed flow mask configurations
Date: Mon, 6 Aug 2018 15:16:26 +0200 [thread overview]
Message-ID: <20180806131626.GW5211@6wind.com> (raw)
In-Reply-To: <1533553127-18664-1-git-send-email-matan@mellanox.com>
On Mon, Aug 06, 2018 at 10:58:47AM +0000, Matan Azrad wrote:
> The rte_flow meaning of zero flow mask configuration is to match all
> the range of the item value.
> For example, the flow eth / ipv4 dst spec 1.2.3.4 dst mask 0.0.0.0
> should much all the ipv4 traffic from the rte_flow API perspective.
>
> From some kernel perspectives the above rule means to ignore all the
> ipv4 traffic (e.g. Ubuntu 16.04, 4.15.10).
>
> Due to the fact that the tap PMD should provide the rte_flow meaning,
> it is necessary to ignore the spec in case the mask is zero when it
> forwards such like flows to the kernel.
> So, the above rule should be translated to eth / ipv4 to get the
> correct meaning.
>
> Ignore spec configurations when the mask is zero.
>
> Fixes: de96fe68ae95 ("net/tap: add basic flow API patterns and actions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/net/tap/tap_flow.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> V2:
> Address Adrien comments to fix also the spec=0 check.
Thanks,
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2018-08-06 13:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 10:33 [dpdk-stable] [PATCH] " Matan Azrad
2018-08-02 12:03 ` Wiles, Keith
2018-08-02 14:27 ` [dpdk-stable] [dpdk-dev] " Adrien Mazarguil
2018-08-02 17:52 ` Matan Azrad
2018-08-03 8:20 ` Adrien Mazarguil
2018-08-05 6:10 ` Matan Azrad
2018-08-06 9:40 ` Adrien Mazarguil
2018-08-06 9:58 ` Matan Azrad
2018-08-06 10:58 ` [dpdk-stable] [PATCH v2] " Matan Azrad
2018-08-06 13:16 ` Adrien Mazarguil [this message]
2018-08-07 14:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806131626.GW5211@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=matan@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).