From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH 5/5] net/netvsc: integrated VF support
Date: Fri, 14 Sep 2018 08:22:26 -0700 [thread overview]
Message-ID: <20180914082226.08fc223d@xeon-e3> (raw)
In-Reply-To: <03884d78-ac63-4d47-2392-bd1e3cab4d58@intel.com>
On Fri, 14 Sep 2018 13:57:58 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 8/30/2018 11:35 PM, Stephen Hemminger wrote:
> > From: Stephen Hemminger <sthemmin@microsoft.com>
> >
> > Integrate accelerated networking support into netvsc PMD.
> > This allows netvsc to manage VF without using failsafe or vdev_netvsc.
> > For the exception vswitch path some tests like transmit
> > get a 22% increase in packets/sec.
> > For the VF path, the code is slightly shorter but has no
> > real change in performance.
> >
> > Pro:
> > * using netvsc is more like other DPDK NIC's
> > * the exception packet uses less CPU
> > * much smaller code size
> > * no locking required on VF transmit/receive path
> > * no legacy Linux network device to get mangled by userspace
> > * much simpler (1K vs 9K) LOC
> > * unified extended statistics
> >
> > Con:
> > * using netvsc has more complex startup model
> > * no bifurcated driver support
> > * no flow support (since host does not have flow API).
> > * no tunnel offload support
> > * no receive interrupt support
> >
> > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> > ---
> > devtools/checkpatches.sh | 2 +-
> > doc/guides/nics/netvsc.rst | 12 +-
> > doc/guides/rel_notes/release_18_11.rst | 14 +-
> > drivers/net/netvsc/Makefile | 1 +
> > drivers/net/netvsc/hn_ethdev.c | 109 +++++-
> > drivers/net/netvsc/hn_nvs.c | 11 +-
> > drivers/net/netvsc/hn_nvs.h | 9 +
> > drivers/net/netvsc/hn_rndis.c | 31 ++
> > drivers/net/netvsc/hn_rndis.h | 1 +
> > drivers/net/netvsc/hn_rxtx.c | 136 ++++---
> > drivers/net/netvsc/hn_var.h | 43 ++-
> > drivers/net/netvsc/hn_vf.c | 512 +++++++++++++++++++++++++
> > drivers/net/netvsc/meson.build | 2 +-
> > 13 files changed, 799 insertions(+), 84 deletions(-)
> > create mode 100644 drivers/net/netvsc/hn_vf.c
> >
> > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> > index ba795ad1dc36..db7afc43d4c0 100755
> > --- a/devtools/checkpatches.sh
> > +++ b/devtools/checkpatches.sh
> > @@ -1,4 +1,4 @@
> > -#! /bin/sh
> > +#! /bin/bash
> > # SPDX-License-Identifier: BSD-3-Clause
> > # Copyright 2015 6WIND S.A.
>
> This tool patch shouldn't be part of driver update, would you mind sending a
> separate patch for it?
Sorry, that slipped in. Will drop it.
next prev parent reply other threads:[~2018-09-14 15:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 22:35 [dpdk-dev] [PATCH 0/5] netvsc changes for 18.11 Stephen Hemminger
2018-08-30 22:35 ` [dpdk-dev] [PATCH 1/5] bus/vmbus: add devargs support Stephen Hemminger
2018-09-14 12:46 ` Ferruh Yigit
2018-09-14 13:06 ` Gaëtan Rivet
2018-09-14 13:19 ` Ferruh Yigit
2018-09-14 13:58 ` Gaëtan Rivet
2018-09-14 15:21 ` Stephen Hemminger
2018-08-30 22:35 ` [dpdk-dev] [PATCH 2/5] net/netvsc: allow tuning latency with devargs Stephen Hemminger
2018-09-14 12:47 ` Ferruh Yigit
2018-08-30 22:35 ` [dpdk-dev] [PATCH 3/5] net/netvsc: exhausting transmit descriptors is not an error Stephen Hemminger
2018-08-30 22:35 ` [dpdk-dev] [PATCH 4/5] net/netvsc: implement link state change callback Stephen Hemminger
2018-08-31 8:25 ` Gaëtan Rivet
2018-08-31 15:13 ` Stephen Hemminger
2018-08-30 22:35 ` [dpdk-dev] [PATCH 5/5] net/netvsc: integrated VF support Stephen Hemminger
2018-09-14 12:57 ` Ferruh Yigit
2018-09-14 15:22 ` Stephen Hemminger [this message]
2018-08-31 12:04 ` [dpdk-dev] [PATCH 0/5] netvsc changes for 18.11 Ferruh Yigit
2018-08-31 15:15 ` Stephen Hemminger
2018-08-31 16:56 ` Thomas Monjalon
2018-09-14 13:25 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914082226.08fc223d@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).