From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Xiaoyu Min <jackmin@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Shagun Agarwal <shaguna@chelsio.com>,
Nirranjan Kirubaharan <nirranjan@chelsio.com>,
Indranil Choudhury <indranil@chelsio.com>
Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add flow api actions to modify IP addresses
Date: Wed, 19 Sep 2018 20:44:14 +0530 [thread overview]
Message-ID: <20180919151412.GA6366@chelsio.com> (raw)
In-Reply-To: <20180918075606.edfevp3iuibozmsu@MTBC-JACKMIN.mtl.com>
On Tuesday, September 09/18/18, 2018 at 13:26:06 +0530, Xiaoyu Min wrote:
> >
> > static int
> > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> > index f8ba71cdb..48c3c606e 100644
> > --- a/lib/librte_ethdev/rte_flow.h
> > +++ b/lib/librte_ethdev/rte_flow.h
> > @@ -1505,6 +1505,34 @@ enum rte_flow_action_type {
> > * error.
> > */
> > RTE_FLOW_ACTION_TYPE_NVGRE_DECAP,
> > +
> > + /**
> > + * Modify IPv4 source address
> > + *
> > + * See struct rte_flow_action_set_ipv4.
> > + */
> > + RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC,
> > +
> > + /**
> > + * Modify IPv4 destination address
> > + *
> > + * See struct rte_flow_action_set_ipv4.
> > + */
> > + RTE_FLOW_ACTION_TYPE_SET_IPV4_DST,
> > +
> > + /**
> > + * Modify IPv6 source address
> > + *
> > + * See struct rte_flow_action_set_ipv6.
> > + */
> > + RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC,
> > +
> > + /**
> > + * Modify IPv6 destination address
> > + *
> > + * See struct rte_flow_action_set_ipv6.
> > + */
> > + RTE_FLOW_ACTION_TYPE_SET_IPV6_DST,
> > };
> Hey Rahul,
>
> Sorry for the late response. Just a small comment:
>
> We would need the corresponding RTE_FLOW_ITEM_TYPE_* specified in pattern.
> i.e RTE_FLOW_ITEM_TYPE_IPV6 must be in pattern for action RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC
> otherwise RTE_FLOW_ERROR_TYPE_ACTION return.
> Would be better to document this in comments and __rte_flow.rst__
>
> What do you think?
>
Ok. Will update the comment and doc.
Thanks,
Rahul
next prev parent reply other threads:[~2018-09-19 15:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 9:56 [dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API Rahul Lakkireddy
2018-06-22 9:56 ` [dpdk-dev] [RFC 1/3] ethdev: add flow api actions to modify IP addresses Rahul Lakkireddy
2018-06-22 9:56 ` [dpdk-dev] [RFC 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers Rahul Lakkireddy
2018-06-22 9:56 ` [dpdk-dev] [RFC 3/3] net/cxgbe: add flow actions to modify IP and TCP/UDP port address Rahul Lakkireddy
2018-06-26 10:32 ` [dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API Thomas Monjalon
2018-07-02 9:09 ` Jack Min
2018-07-02 12:04 ` Rahul Lakkireddy
2018-07-03 2:27 ` Jack Min
2018-07-03 13:39 ` Rahul Lakkireddy
2018-07-04 1:11 ` Jack Min
2018-07-05 20:16 ` Adrien Mazarguil
2018-07-10 13:14 ` Rahul Lakkireddy
2018-08-01 23:35 ` Jack Min
2018-08-02 14:59 ` Rahul Lakkireddy
2018-08-13 13:36 ` [dpdk-dev] [RFC v2 " Rahul Lakkireddy
2018-08-13 13:36 ` [dpdk-dev] [RFC v2 1/3] ethdev: add flow api actions to modify IP addresses Rahul Lakkireddy
2018-09-18 7:56 ` Xiaoyu Min
2018-09-19 15:14 ` Rahul Lakkireddy [this message]
2018-08-13 13:36 ` [dpdk-dev] [RFC v2 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers Rahul Lakkireddy
2018-09-18 9:29 ` Xiaoyu Min
2018-09-19 15:16 ` Rahul Lakkireddy
2018-08-13 13:36 ` [dpdk-dev] [RFC v2 3/3] net/cxgbe: add flow actions to modify IP and TCP/UDP port address Rahul Lakkireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919151412.GA6366@chelsio.com \
--to=rahul.lakkireddy@chelsio.com \
--cc=dev@dpdk.org \
--cc=indranil@chelsio.com \
--cc=jackmin@mellanox.com \
--cc=nirranjan@chelsio.com \
--cc=shaguna@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).