From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
dev@dpdk.org, stable@dpdk.org, jiayu.hu@intel.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask
Date: Mon, 1 Oct 2018 21:23:58 +0530 [thread overview]
Message-ID: <20181001155357.GA1570@jerin> (raw)
In-Reply-To: <20d2c484-6c86-7c55-4973-d55f1da20a6c@intel.com>
-----Original Message-----
> Date: Mon, 1 Oct 2018 14:45:02 +0100
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, Olivier Matz
> <olivier.matz@6wind.com>
> CC: dev@dpdk.org, stable@dpdk.org, jiayu.hu@intel.com
> Subject: Re: [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
> Thunderbird/52.9.1
>
>
> On 9/13/2018 2:47 PM, Jerin Jacob wrote:
> > Fixes missing PKT_TX_UDP_SEG value in PKT_TX_OFFLOAD_MASK.
> >
> > Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload")
> > Cc: stable@dpdk.org
> > Cc: jiayu.hu@intel.com
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> > lib/librte_mbuf/rte_mbuf.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> > index 9ce5d76d7..6a5dbbc8f 100644
> > --- a/lib/librte_mbuf/rte_mbuf.h
> > +++ b/lib/librte_mbuf/rte_mbuf.h
> > @@ -343,7 +343,8 @@ extern "C" {
> > PKT_TX_VLAN_PKT | \
> > PKT_TX_TUNNEL_MASK | \
> > PKT_TX_MACSEC | \
> > - PKT_TX_SEC_OFFLOAD)
> > + PKT_TX_SEC_OFFLOAD | \
> > + PKT_TX_UDP_SEG)
>
> Also can you sort the list, it seem there was an intention to sort from high
> bits to low, but broken, it makes easy to recognize missing items later.
I think, sorting from high bits to low bits makes it easy to recognize.
If it broken, How about fixing that(order based on bits) while rebasing to top of tree?
I don't have strong opinion or sorting based on bit order vs name. Just shared
my thought. Let me know your opinion, I will update it accordingly.
next prev parent reply other threads:[~2018-10-01 15:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180913134707.23698-1-jerin.jacob@caviumnetworks.com>
2018-09-13 13:47 ` Jerin Jacob
2018-10-01 13:45 ` Ferruh Yigit
2018-10-01 15:53 ` Jerin Jacob [this message]
2018-10-01 16:13 ` Ferruh Yigit
[not found] ` <20181002105142.24333-1-jerin.jacob@caviumnetworks.com>
2018-10-02 10:51 ` [dpdk-stable] [dpdk-dev] [PATCH v2 2/2] " Jerin Jacob
2018-10-04 2:31 ` Hu, Jiayu
2018-10-04 16:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001155357.GA1570@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jiayu.hu@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).