From: Bruce Richardson <bruce.richardson@intel.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org,
yipeng1.wang@intel.com, gavin.hu@arm.com,
dharmik.thakkar@arm.com, nd@arm.com
Subject: Re: [dpdk-dev] [PATCH v5 2/5] hash: support do not free on delete
Date: Tue, 23 Oct 2018 11:30:06 +0100 [thread overview]
Message-ID: <20181023103005.GB18800@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1540268524-126673-3-git-send-email-honnappa.nagarahalli@arm.com>
On Mon, Oct 22, 2018 at 11:22:01PM -0500, Honnappa Nagarahalli wrote:
> rte_hash_lookup_xxx APIs return the index of slot in
> the key store. Application(reader) can use that index to reference
> other data structures in its scope. Because of this, the
> index should not be freed till the application completes
> using the index.
> RTE_HASH_EXTRA_FLAGS_NO_FREE_ON_DEL is introduced to support this.
> When this flag is enabled rte_hash_del_xxx APIs do not free the
> key-store index/internal memory associated with the deleted
> entry. The new API rte_hash_free_key_with_position should be called
> to free the key-store index/internal memory after calling
> rte_hash_del_xxx APIs.
>
> Suggested-by: Yipeng Wang <yipeng1.wang@intel.com>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Yipeng Wang <yipeng1.wang@arm.com>
> ---
As before, fix email in reviewed-by.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2018-10-23 10:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 4:21 [dpdk-dev] [PATCH v5 0/5] Address reader-writer concurrency in rte_hash Honnappa Nagarahalli
2018-10-23 4:22 ` [dpdk-dev] [PATCH v5 1/5] hash: separate multi-writer from rw-concurrency Honnappa Nagarahalli
2018-10-23 10:25 ` Bruce Richardson
2018-10-23 4:22 ` [dpdk-dev] [PATCH v5 2/5] hash: support do not free on delete Honnappa Nagarahalli
2018-10-23 10:30 ` Bruce Richardson [this message]
2018-10-23 4:22 ` [dpdk-dev] [PATCH v5 3/5] hash: fix key store element alignment Honnappa Nagarahalli
2018-10-23 10:31 ` Bruce Richardson
2018-10-23 4:22 ` [dpdk-dev] [PATCH v5 4/5] hash: add lock-free read-write concurrency Honnappa Nagarahalli
2018-10-23 11:52 ` Bruce Richardson
2018-10-23 4:22 ` [dpdk-dev] [PATCH v5 5/5] test/hash: read-write lock-free concurrency test Honnappa Nagarahalli
2018-10-23 11:54 ` Bruce Richardson
2018-10-23 14:15 ` Honnappa Nagarahalli
2018-10-23 14:20 ` Bruce Richardson
2018-10-23 15:52 ` Honnappa Nagarahalli
2018-10-23 11:56 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023103005.GB18800@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).