From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, wisamm@mellanox.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] pci: fix parsing of address without function number
Date: Mon, 12 Nov 2018 10:29:05 +0100 [thread overview]
Message-ID: <20181112092905.g5vxszu5okxz4pzn@bidouze.vm.6wind.com> (raw)
In-Reply-To: <20181111235856.31429-1-thomas@monjalon.net>
On Mon, Nov 12, 2018 at 12:58:56AM +0100, Thomas Monjalon wrote:
> If the last part of the PCI address (function number) is missing,
> the parsing was successful, assuming function 0.
> The call to strtoul is not returning an error in such a case,
> so an explicit check is inserted before.
>
> This bug has always been there in older parsing macros:
> - GET_PCIADDR_FIELD
> - GET_BLACKLIST_FIELD
>
Returning 0, that's understandable, but errno not being set
is rather lame from strtoul.
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Reported-by: Wisam Jaddo <wisamm@mellanox.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> lib/librte_pci/rte_pci.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/librte_pci/rte_pci.c b/lib/librte_pci/rte_pci.c
> index 530738dbd..f400178bb 100644
> --- a/lib/librte_pci/rte_pci.c
> +++ b/lib/librte_pci/rte_pci.c
> @@ -30,6 +30,10 @@ get_u8_pciaddr_field(const char *in, void *_u8, char dlm)
> uint8_t *u8 = _u8;
> char *end;
>
> + /* empty string is an error though strtoul() returns 0 */
> + if (*in == '\0')
> + return NULL;
> +
> errno = 0;
> val = strtoul(in, &end, 16);
> if (errno != 0 || end[0] != dlm || val > UINT8_MAX) {
> --
> 2.19.0
>
--
Gaëtan Rivet
6WIND
next prev parent reply other threads:[~2018-11-12 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 23:58 Thomas Monjalon
2018-11-12 9:29 ` Gaëtan Rivet [this message]
2018-11-13 17:00 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112092905.g5vxszu5okxz4pzn@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=wisamm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).