DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Leah Tekoa <Leah@Ethernitynet.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Ouyang Changchun <changchun.ouyang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit
Date: Mon, 19 Nov 2018 09:10:42 -0800	[thread overview]
Message-ID: <20181119091042.1977b022@xeon-e3> (raw)
In-Reply-To: <9f22d89841c440c32235117e1a4fe223f97c7f8e.1542616118.git.leah@ethernitynet.com>

On Mon, 19 Nov 2018 08:38:44 +0000
Leah Tekoa <Leah@Ethernitynet.com> wrote:

> -	link = dev->data->dev_link;
> +	memcpy(&link, &dev->data->dev_link, sizeof(struct rte_eth_link));
>  

If structure assignment and memcpy don't give same result, then
you have a buggy compiler.

      parent reply	other threads:[~2018-11-19 17:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-19  8:38 Leah Tekoa
2018-11-19 11:43 ` Ferruh Yigit
2018-11-19 11:55   ` Leah Tekoa
2018-11-19 17:10 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181119091042.1977b022@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=Leah@Ethernitynet.com \
    --cc=changchun.ouyang@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).