patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Joyce Kong <joyce.kong@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
	"gavin.hu@arm.com" <gavin.hu@arm.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v3] config: enable more than 128 cores for Arm64 platform
Date: Thu, 22 Nov 2018 07:08:51 +0000	[thread overview]
Message-ID: <20181122070832.GA15701@jerin> (raw)
In-Reply-To: <1542870074-142423-1-git-send-email-joyce.kong@arm.com>

-----Original Message-----
> Date: Thu, 22 Nov 2018 15:01:14 +0800
> From: Joyce Kong <joyce.kong@arm.com>
> To: dev@dpdk.org
> CC: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
>  Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, stable@dpdk.org
> Subject: [PATCH v3] config: enable more than 128 cores for Arm64 platform
> X-Mailer: git-send-email 2.7.4
> 
> 
> When running dpdk applications on cores whose ids are bigger
> than original max_core setting, eal error as below:
> EAL: Detected 104 lcore(s)
> EAL: Detected 2 NUMA nodes
> EAL: invalid core list
> -l CORELIST core indexes between 0 and 128
> 
> The fix is to increase max_core to 256 on Arm64 platform.
> 
> Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
>  config/arm/meson.build                     | 5 +++--
>  config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index b755138..9b5f09c 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -46,13 +46,14 @@ flags_common_default = [
> 
>  flags_generic = [
>         ['RTE_MACHINE', '"armv8a"'],
> +    ['RTE_MAX_LCORE', 256],
>         ['RTE_CACHE_LINE_SIZE', 128]]
>  flags_cavium = [
>         ['RTE_MACHINE', '"thunderx"'],
>         ['RTE_CACHE_LINE_SIZE', 128],
>         ['RTE_MAX_NUMA_NODES', 2],
> -       ['RTE_MAX_LCORE', 96],
> -       ['RTE_MAX_VFIO_GROUPS', 128],
> +    ['RTE_MAX_LCORE', 256],

thunderx has only 96 cores. It the "thunderx2" which has more cores.
There no speerate config "thunderx2", it is using generic armv8 config.
So this specific line of change is not needed.

> +    ['RTE_MAX_VFIO_GROUPS', 128],
>         ['RTE_USE_C11_MEM_MODEL', false]]
>  flags_dpaa = [
>         ['RTE_MACHINE', '"dpaa"'],
> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
> index 1842744..a6ed90c 100644
> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
> @@ -6,3 +6,4 @@
> 
>  CONFIG_RTE_TOOLCHAIN="gcc"
>  CONFIG_RTE_TOOLCHAIN_GCC=y
> +CONFIG_RTE_MAX_LCORE=256
> --
> 2.7.4
> 

  reply	other threads:[~2018-11-22  7:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1542798625-46722-1-git-send-email-joyce.kong@arm.com>
2018-11-21 11:10 ` [dpdk-stable] [PATCH v1 1/2] config: enable more than 128 cores for Arm platform Joyce Kong
2018-11-21 11:10 ` [dpdk-stable] [PATCH v1 2/2] config: enable more than 128 cores for meson build Joyce Kong
2018-11-21 11:27 ` [dpdk-stable] [PATCH v2] config: enable more than 128 cores for Arm64 platform Joyce Kong
2018-11-21 11:34   ` Jerin Jacob
2018-11-22  7:01     ` Joyce Kong (Arm Technology China)
2018-11-22  7:01 ` [dpdk-stable] [PATCH v3] " Joyce Kong
2018-11-22  7:08   ` Jerin Jacob [this message]
2018-11-22  7:43     ` Joyce Kong (Arm Technology China)
2018-11-22  7:37   ` [dpdk-stable] [PATCH v4] " Joyce Kong
2018-11-22 11:04     ` Jerin Jacob
2018-11-23  0:49       ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181122070832.GA15701@jerin \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=gavin.hu@arm.com \
    --cc=joyce.kong@arm.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).