From: Neil Horman <nhorman@tuxdriver.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, echaudro@redhat.com
Subject: Re: [dpdk-dev] [PATCH 1/2] devtools: report the incorrect section when complaining
Date: Wed, 28 Nov 2018 07:34:32 -0500 [thread overview]
Message-ID: <20181128123432.GC32491@hmswarspite.think-freely.org> (raw)
In-Reply-To: <1543400933-1723-1-git-send-email-david.marchand@redhat.com>
On Wed, Nov 28, 2018 at 11:28:52AM +0100, David Marchand wrote:
> It does not hurt reporting the incriminated section.
>
> Before:
> ERROR: symbol rte_meter_trtcm_rfc4115_color_aware_check is added in a
> section other than the EXPERIMENTAL section of the version map
>
> After:
> ERROR: symbol rte_meter_trtcm_rfc4115_color_aware_check is added in
> +EXPERIMENTAL section other than the EXPERIMENTAL section of the
> version map
>
nit: Its a bit odd in the changelog to have an example in which the incorect
section being reported matches the expected section. I.e. its confusing to read
"... is added in +EXPERIMENTAL section other than the EXPERIMENTAL section".
Might be better to change the language of the report below and the example to be
something like:
ERROR: symbol <SYMBOL> is added in the <VERSION> section, but is expected to be
added in the EXPERIMENTAL section
ACK to the notion of reporting the offending section though. Thats a good idea.
Neil
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>
> Used http://patchwork.dpdk.org/patch/48354/ to test.
>
> ---
> devtools/check-symbol-change.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index 1d21e91..66741be 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -115,7 +115,7 @@ check_for_rule_violations()
> if [ $? -ne 0 ]
> then
> echo -n "ERROR: symbol $symname "
> - echo -n "is added in a section "
> + echo -n "is added in $secname section "
> echo -n "other than the EXPERIMENTAL "
> echo "section of the version map"
> ret=1
> --
> 1.8.3.1
>
>
next prev parent reply other threads:[~2018-11-28 12:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 10:28 David Marchand
2018-11-28 10:28 ` [dpdk-dev] [PATCH 2/2] devtools: drop '+' from the section name David Marchand
2018-11-28 12:34 ` Neil Horman [this message]
2018-11-28 13:07 ` [dpdk-dev] [PATCH 1/2] devtools: report the incorrect section when complaining David Marchand
2018-11-28 21:23 ` Neil Horman
2018-11-30 12:32 ` [dpdk-dev] [PATCH v2 " David Marchand
2018-11-30 12:32 ` [dpdk-dev] [PATCH v2 2/2] devtools: drop '+' from the section name David Marchand
2018-11-30 15:28 ` Neil Horman
2018-11-30 15:43 ` David Marchand
2018-11-30 17:17 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128123432.GC32491@hmswarspite.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=echaudro@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).