From: Stephen Hemminger <stephen@networkplumber.org>
To: Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] helloworld: Windows DPDK sample application is compiled and built using eal and kvargs libraries in order to add windows support in the mainline repository.
Date: Thu, 29 Nov 2018 10:15:06 -0800 [thread overview]
Message-ID: <20181129101506.32c9de3c@xeon-e3> (raw)
In-Reply-To: <20181129050504.26996-1-pallavi.kadam@intel.com>
On Wed, 28 Nov 2018 21:05:04 -0800
Pallavi Kadam <pallavi.kadam@intel.com> wrote:
> +// If we define WIN32_LEAN_AND_MEAN, winsock isn't included by default. We can then include it in specific header files as we need later.
> +#define WIN32_LEAN_AND_MEAN
All this is Windows code, it would be best if the code style of the new code
matches the rest of the DPDK. The DPDK follows subset of Linux kernel style
standard. In that standard C++ style comments are not used.
next prev parent reply other threads:[~2018-11-29 18:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 5:05 Pallavi Kadam
2018-11-29 18:15 ` Stephen Hemminger [this message]
2018-11-30 16:04 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129101506.32c9de3c@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=pallavi.kadam@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).