From: Neil Horman <nhorman@tuxdriver.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, echaudro@redhat.com
Subject: Re: [dpdk-dev] [PATCH v2 2/2] devtools: drop '+' from the section name
Date: Fri, 30 Nov 2018 10:28:17 -0500 [thread overview]
Message-ID: <20181130152817.GI24285@hmswarspite.think-freely.org> (raw)
In-Reply-To: <1543581122-22501-2-git-send-email-david.marchand@redhat.com>
On Fri, Nov 30, 2018 at 01:32:02PM +0100, David Marchand wrote:
> The incriminated commit did relax the condition to catch all sections
> but dropped the + removal which can triggers false detection of the
> special EXPERIMENTAL section when adding symbols and the section in the
> same patch.
>
> Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> devtools/check-symbol-change.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index 4b8d9f3..020da7e 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -31,6 +31,7 @@ build_map_changes()
> # Triggering this rule sets in_sec to 1, which actives the
> # symbol rule below
> /^.*{/ {
> + gsub("+", "");
> if (in_map == 1) {
> sec=$(NF-1); in_sec=1;
> }
> --
> 1.8.3.1
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Thanks!
Neil
next prev parent reply other threads:[~2018-11-30 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 10:28 [dpdk-dev] [PATCH 1/2] devtools: report the incorrect section when complaining David Marchand
2018-11-28 10:28 ` [dpdk-dev] [PATCH 2/2] devtools: drop '+' from the section name David Marchand
2018-11-28 12:34 ` [dpdk-dev] [PATCH 1/2] devtools: report the incorrect section when complaining Neil Horman
2018-11-28 13:07 ` David Marchand
2018-11-28 21:23 ` Neil Horman
2018-11-30 12:32 ` [dpdk-dev] [PATCH v2 " David Marchand
2018-11-30 12:32 ` [dpdk-dev] [PATCH v2 2/2] devtools: drop '+' from the section name David Marchand
2018-11-30 15:28 ` Neil Horman [this message]
2018-11-30 15:43 ` David Marchand
2018-11-30 17:17 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130152817.GI24285@hmswarspite.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=echaudro@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).