From: Neil Horman <nhorman@tuxdriver.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org, tredaelli@redhat.com,
ferruh.yigit@intel.com, amr.mokhtar@intel.com
Subject: Re: [dpdk-stable] [PATCH] bbdev: add missing experimental tags
Date: Wed, 5 Dec 2018 07:23:29 -0500 [thread overview]
Message-ID: <20181205122329.GB6752@hmswarspite.think-freely.org> (raw)
In-Reply-To: <1543957065-20990-1-git-send-email-david.marchand@redhat.com>
On Tue, Dec 04, 2018 at 09:57:45PM +0100, David Marchand wrote:
> Those two symbols are missing the experimental tag in the library
> header.
> Because of this, a user can try to call this symbol without being aware
> this is an experimental api (neither compilation nor link warning).
>
> Fixes: 4935e1e9f76e ("bbdev: introduce wireless base band device lib")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/librte_bbdev/rte_bbdev_op.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_bbdev/rte_bbdev_op.h b/lib/librte_bbdev/rte_bbdev_op.h
> index 83f62c2..c9200b5 100644
> --- a/lib/librte_bbdev/rte_bbdev_op.h
> +++ b/lib/librte_bbdev/rte_bbdev_op.h
> @@ -459,7 +459,7 @@ struct rte_bbdev_op_pool_private {
> * Operation type as string or NULL if op_type is invalid
> *
> */
> -const char*
> +__rte_experimental const char *
> rte_bbdev_op_type_str(enum rte_bbdev_op_type op_type);
>
> /**
> @@ -482,7 +482,7 @@ struct rte_bbdev_op_pool_private {
> * - Pointer to a mempool on success,
> * - NULL pointer on failure.
> */
> -struct rte_mempool *
> +__rte_experimental struct rte_mempool *
> rte_bbdev_op_pool_create(const char *name, enum rte_bbdev_op_type type,
> unsigned int num_elements, unsigned int cache_size,
> int socket_id);
> --
> 1.8.3.1
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
next prev parent reply other threads:[~2018-12-05 12:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 20:57 David Marchand
2018-12-05 12:23 ` Neil Horman [this message]
2018-12-05 16:46 ` Mokhtar, Amr
2018-12-14 9:54 ` [dpdk-stable] [dpdk-dev] " Akhil Goyal
2018-12-14 10:00 ` David Marchand
2018-12-14 12:35 ` Neil Horman
2018-12-14 12:52 ` Mokhtar, Amr
2018-12-18 10:37 ` David Marchand
2018-12-18 10:43 ` Akhil Goyal
2018-12-18 10:48 ` David Marchand
2018-12-19 9:20 ` Mokhtar, Amr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205122329.GB6752@hmswarspite.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=amr.mokhtar@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).