DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Keith Wiles <keith.wiles@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal:missing newline on RTE_LOG msg
Date: Mon, 17 Dec 2018 10:25:35 +0100	[thread overview]
Message-ID: <20181217092535.jzp6icioklwxzlta@bidouze.vm.6wind.com> (raw)
In-Reply-To: <20181216230103.96422-1-keith.wiles@intel.com>

Hi Keith,

On Sun, Dec 16, 2018 at 05:01:03PM -0600, Keith Wiles wrote:
> Add a missing newline to a RTE_LOG message.
> 

I think it might interest stable@dpdk.org, and you might as well include
a fixline reference.

> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  lib/librte_eal/common/rte_option.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c
> index 02d59a869..7605190c3 100644
> --- a/lib/librte_eal/common/rte_option.c
> +++ b/lib/librte_eal/common/rte_option.c
> @@ -36,7 +36,7 @@ rte_option_register(struct rte_option *opt)
>  {
>  	TAILQ_FOREACH(option, &rte_option_list, next) {
>  		if (strcmp(opt->opt_str, option->opt_str) == 0)
> -			RTE_LOG(INFO, EAL, "Option %s has already been registered.",
> +			RTE_LOG(INFO, EAL, "Option %s has already been registered.\n",
>  					opt->opt_str);
>  			return;
>  	}
> -- 
> 2.17.1
> 

-- 
Gaëtan Rivet
6WIND

  reply	other threads:[~2018-12-17  9:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-16 23:01 Keith Wiles
2018-12-17  9:25 ` Gaëtan Rivet [this message]
2018-12-19 22:53   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217092535.jzp6icioklwxzlta@bidouze.vm.6wind.com \
    --to=gaetan.rivet@6wind.com \
    --cc=dev@dpdk.org \
    --cc=keith.wiles@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).