From: Jens Freimann <jfreimann@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, tiwei.bie@intel.com, Gavin.Hu@arm.com
Subject: Re: [dpdk-dev] [PATCH v13 09/10] net/virtio-user: fail if q used with packed vq
Date: Mon, 17 Dec 2018 20:27:10 +0100 [thread overview]
Message-ID: <20181217192710.kjeor5pgf4lautom@jenstp.localdomain> (raw)
In-Reply-To: <e7b046ee-6c71-aa53-7c6c-4b244517672a@redhat.com>
On Mon, Dec 17, 2018 at 05:52:08PM +0100, Maxime Coquelin wrote:
>I think you meant control queue in the title?
>
>On 12/14/18 4:59 PM, Jens Freimann wrote:
>>Until we have support for ctrl virtqueues let's disable it and
>>fail device initalization if specified as a parameter.
>>
>>Signed-off-by: Jens Freimann <jfreimann@redhat.com>
>>---
>> drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 ++++++++--
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>
>>diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
>>index 697ba4ae8..14597eb73 100644
>>--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
>>+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
>>@@ -467,10 +467,16 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
>> if (!in_order)
>> dev->unsupported_features |= (1ull << VIRTIO_F_IN_ORDER);
>>- if (packed_vq)
>>+ if (packed_vq) {
>>+ if (cq) {
>>+ PMD_INIT_LOG(ERR, "control vq not supported with "
>
>Maybe change to "not supported *yet*".
sure, no problem.
regards,
Jens
next prev parent reply other threads:[~2018-12-17 19:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 15:59 [dpdk-dev] [PATCH v13 00/10] implement packed virtqueues Jens Freimann
2018-12-14 15:59 ` [dpdk-dev] [PATCH v13 01/10] net/virtio: add packed virtqueue defines Jens Freimann
2018-12-17 15:45 ` Maxime Coquelin
2018-12-14 15:59 ` [dpdk-dev] [PATCH v13 02/10] net/virtio: add packed virtqueue helpers Jens Freimann
2018-12-17 16:09 ` Maxime Coquelin
2018-12-17 16:30 ` Maxime Coquelin
2018-12-14 15:59 ` [dpdk-dev] [PATCH v13 03/10] net/virtio: vring init for packed queues Jens Freimann
2018-12-17 16:15 ` Maxime Coquelin
2018-12-14 15:59 ` [dpdk-dev] [PATCH v13 04/10] net/virtio: dump packed virtqueue data Jens Freimann
2018-12-14 15:59 ` [dpdk-dev] [PATCH v13 05/10] net/virtio: implement transmit path for packed queues Jens Freimann
2018-12-17 16:35 ` Maxime Coquelin
2018-12-14 15:59 ` [dpdk-dev] [PATCH v13 06/10] net/virtio: implement receive " Jens Freimann
2018-12-17 16:46 ` Maxime Coquelin
2018-12-14 15:59 ` [dpdk-dev] [PATCH v13 07/10] net/virtio: add virtio send command packed queue support Jens Freimann
2018-12-17 16:48 ` Maxime Coquelin
2018-12-14 15:59 ` [dpdk-dev] [PATCH v13 08/10] net/virtio-user: add option to use packed queues Jens Freimann
2018-12-17 16:49 ` Maxime Coquelin
2018-12-14 15:59 ` [dpdk-dev] [PATCH v13 09/10] net/virtio-user: fail if q used with packed vq Jens Freimann
2018-12-17 16:52 ` Maxime Coquelin
2018-12-17 19:27 ` Jens Freimann [this message]
2018-12-14 15:59 ` [dpdk-dev] [PATCH v13 10/10] net/virtio: enable packed virtqueues by default Jens Freimann
2018-12-17 16:52 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217192710.kjeor5pgf4lautom@jenstp.localdomain \
--to=jfreimann@redhat.com \
--cc=Gavin.Hu@arm.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).