From: Tiwei Bie <tiwei.bie@intel.com>
To: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org,
stable@dpdk.org, ogawa.yasufumi@lab.ntt.co.jp
Subject: Re: [dpdk-stable] [PATCH] net/vhost: fix double free of MAC addrs
Date: Wed, 19 Dec 2018 17:15:33 +0800 [thread overview]
Message-ID: <20181219091533.GB32582@dpdk-tbie.sh.intel.com> (raw)
In-Reply-To: <201812190440.wBJ4cabt027283@ccmail04.silk.ntt-tx.co.jp>
On Wed, Dec 19, 2018 at 01:37:18PM +0900, Hideyuki Yamashita wrote:
> The common data freeing has been moved to rte_eth_dev_release_port(),
> so freeing mac_addrs like this in eth_dev_close() is unnecessary and
> will cause double free.
>
> Fixes: e16adf08e54d ("ethdev: free all common data when releasing port")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
> Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> ---
> drivers/net/vhost/rte_eth_vhost.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index 42bdfcbd5..b2cda0483 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -1000,7 +1000,6 @@ eth_dev_close(struct rte_eth_dev *dev)
> for (i = 0; i < dev->data->nb_tx_queues; i++)
> rte_free(dev->data->tx_queues[i]);
>
> - rte_free(dev->data->mac_addrs);
> free(internal->dev_name);
> free(internal->iface_name);
> rte_free(internal);
> --
> 2.18.0
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
next prev parent reply other threads:[~2018-12-19 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 4:37 Hideyuki Yamashita
2018-12-19 9:15 ` Tiwei Bie [this message]
2018-12-20 18:20 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219091533.GB32582@dpdk-tbie.sh.intel.com \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=ogawa.yasufumi@lab.ntt.co.jp \
--cc=stable@dpdk.org \
--cc=yamashita.hideyuki@po.ntt-tx.co.jp \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).