From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, i.maximets@samsung.com, zhihong.wang@intel.com,
jasowang@redhat.com, mst@redhat.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2 0/4] vhost: add missing barriers, move prefetching
Date: Thu, 20 Dec 2018 12:39:10 +0800 [thread overview]
Message-ID: <20181220043910.GA21484@dpdk-tbie.sh.intel.com> (raw)
In-Reply-To: <20181219082113.24455-1-maxime.coquelin@redhat.com>
On Wed, Dec 19, 2018 at 09:21:09AM +0100, Maxime Coquelin wrote:
> This series adds missing read barriers after reading avail index
> for split ring and desc flags for packed ring.
>
> Also, it turns out that some descriptors prefetching are either
> badly placed, or useless, last part of the series fixes that.
>
> With the series applied, I get between 0 and 4% gain depending
> on the benchmark (testpmd txonly/rxonly/io).
>
> Thanks to Jason for reporting the missing read barriers.
>
> Changes since v1:
> =================
> - Drop volatile removal patch (Ilya)
> - Improve commit messages for RMB patches (Ilya)
>
> Maxime Coquelin (4):
> vhost: enforce avail index and desc read ordering
> vhost: enforce desc flags and content read ordering
> vhost: prefetch descriptor after the read barrier
> vhost: remove useless prefetch for packed ring descriptor
>
> lib/librte_vhost/virtio_net.c | 27 ++++++++++++++++++++++-----
> 1 file changed, 22 insertions(+), 5 deletions(-)
Acked-by: Tiwei Bie <tiwei.bie@intel.com>
next prev parent reply other threads:[~2018-12-20 4:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 8:21 Maxime Coquelin
2018-12-19 8:21 ` [dpdk-stable] [PATCH v2 1/4] vhost: enforce avail index and desc read ordering Maxime Coquelin
2018-12-19 15:47 ` Michael S. Tsirkin
2018-12-19 15:50 ` Maxime Coquelin
2018-12-19 8:21 ` [dpdk-stable] [PATCH v2 2/4] vhost: enforce desc flags and content " Maxime Coquelin
2018-12-19 8:21 ` [dpdk-stable] [PATCH v2 3/4] vhost: prefetch descriptor after the read barrier Maxime Coquelin
2018-12-19 8:21 ` [dpdk-stable] [PATCH v2 4/4] vhost: remove useless prefetch for packed ring descriptor Maxime Coquelin
2018-12-19 15:49 ` Michael S. Tsirkin
2018-12-19 15:50 ` [dpdk-stable] [PATCH v2 0/4] vhost: add missing barriers, move prefetching Michael S. Tsirkin
2018-12-19 16:28 ` Ilya Maximets
2018-12-20 4:39 ` Tiwei Bie [this message]
2018-12-20 18:19 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220043910.GA21484@dpdk-tbie.sh.intel.com \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=jasowang@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=stable@dpdk.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).