From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: jozmarti@cisco.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] rte_delay_us can be replaced with user function
Date: Mon, 26 Sep 2016 14:48:37 +0200 [thread overview]
Message-ID: <2018407.6L6irO5Yoa@xps13> (raw)
In-Reply-To: <1474878909-15534-1-git-send-email-jozmarti@cisco.com>
2016-09-26 10:35, jozmarti@cisco.com:
> From: Jozef Martiniak <jozmarti@cisco.com>
>
> When running single-core, some drivers tend to call rte_delay_us for a
> long time, and that is causing packet drops.
> To avoid this, rte_delay_us can be replaced with user-defined delay
> function with:
>
> void rte_delay_us_callback_register(void(*userfunc)(unsigned));
>
> When userfunc==rte_delay_us_block build-in blocking delay function is
> restored.
>
> Signed-off-by: Jozef Martiniak <jozmarti@cisco.com>
Applied, thanks.
Just 2 details (below) were fixed when applying.
> --- a/lib/librte_eal/common/include/generic/rte_cycles.h
> +++ b/lib/librte_eal/common/include/generic/rte_cycles.h
> @@ -180,15 +180,16 @@ rte_get_timer_hz(void)
> default: rte_panic("Invalid timer source specified\n");
> }
> }
> -
This blank line should remain.
> /**
> * Wait at least us microseconds.
> + * This function can be replaced with user-defined function.
> + * @see rte_delay_us_callback_register
[...]
> + * @param userfunc
> + * User function which replaces rte_delay_us. rte_delay_us_block restores
> + * buildin block delay function.
buildin -> builtin
prev parent reply other threads:[~2016-09-26 12:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 12:10 [dpdk-dev] [PATCH] " jozmarti
2016-09-13 20:04 ` Thomas Monjalon
2016-09-21 13:12 ` Thomas Monjalon
2016-09-22 8:37 ` Jozef Martiniak -X (jozmarti - PANTHEON TECHNOLOGIES at Cisco)
2016-09-22 15:08 ` Thomas Monjalon
2016-09-23 6:39 ` [dpdk-dev] [PATCH v3] " jozmarti
2016-09-23 14:03 ` Thomas Monjalon
2016-09-26 8:35 ` jozmarti
2016-09-26 12:48 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2018407.6L6irO5Yoa@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jozmarti@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).