From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/4] RFC: consolidate testing apps to app dir
Date: Tue, 29 Jan 2019 11:52:29 +0000 [thread overview]
Message-ID: <20190129115229.GA80176@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <2309208.nfQRyMXgnH@xps>
On Tue, Jan 29, 2019 at 12:40:37PM +0100, Thomas Monjalon wrote:
> 25/01/2019 21:30, Bruce Richardson:
> > On Fri, Jan 25, 2019 at 08:26:38PM +0000, Bruce Richardson wrote:
> > > The apps for testing are split between the "test" and "app" directories,
> > > with a not-very-clear distinction between the two (at least to my mind).
> > >
> > > Given how the apps are being built, the easiest path to having
> > > cmdline_test, test-acl and test-pipeline build using meson is to
> > > consolidate all these apps back into the app folder and use the logic
> > > there. The bpf folder doesn't contain an actual application, but
> > > rather example bpf code which can be loaded into testpmd. That is
> > > possibly best moved to the examples folder, but I'm open to feedback
> > > on the best place for it.
> > >
> > > With these changes, the "test" folder then becomes the location for
> > > unit tests only.
> > >
> > >
> > > Bruce Richardson (4):
> > > test/cmdline_test: move to app directory
> > > test/test-acl: move to app directory
> > > test/test-pipeline: move to app directory
> > > test/bpf: move to examples folder
> > >
> >
> > Although these patches are for 19.05, I'm sending them now for some early
> > review, as I think we need a deprecation notice for this change in 19.02 if
> > these changes are acceptable to people.
>
> We don't need a deprecation notice, as it is an internal change
> without any impact for the users.
>
Yes, good point. With the make build system these test apps end up in the
app folder anyway. With meson, they aren't yet built, so either way it
isn't a user-visible change.
> > Therefore, please review and let me know any issues people see with this
> > change.
>
> We should move all test apps into the same directory.
> Is there any benefit of keeping unit tests separate?
> It looks more logic to move everything in test/
> but it would make the git history of testpmd more complex.
> The other choice is to move all tests in app/.
>
I'd prefer to keep things in app, for legacy reasons more than anything
else. Not sure about moving the unit tests there too - I sort of like
having them in a separate test directory. However, if others generally
prefer that they too get consolidated into app, I won't complain! :-)
If we do end up moving the tests, another thing to consider is whether we
want to split them up by topic or suite. There are now a lot of C files in
the test folder, which suggests to me we need to split things a little.
> The other split to discuss is between app/ and usertools/.
> We could move user-oriented apps to usertools.
> pdump and proc-info fall into this basket because they
> can be used for debugging purpose.
>
Yes. However, is this better handled via the installation rather than the
build? Even if the source code is moved to the usertools directory, the
actual binaries are going to be placed in the build folder, separate from
the scripts anyway. I'd suggest leaving them as they are, though perhaps
putting in a symlink to them from the usertools folder to make them easier
to find.
/Bruce
next prev parent reply other threads:[~2019-01-29 11:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 20:26 Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 1/4] test/cmdline_test: move to app directory Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 2/4] test/test-acl: " Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 3/4] test/test-pipeline: " Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 4/4] test/bpf: move to examples folder Bruce Richardson
2019-01-25 20:30 ` [dpdk-dev] [PATCH 0/4] RFC: consolidate testing apps to app dir Bruce Richardson
2019-01-29 11:40 ` Thomas Monjalon
2019-01-29 11:52 ` Bruce Richardson [this message]
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 0/5] " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 1/5] test/cmdline_test: move to app directory Bruce Richardson
2019-02-26 9:14 ` Thomas Monjalon
2019-02-26 10:00 ` Bruce Richardson
2019-02-26 11:24 ` Bruce Richardson
2019-02-26 12:20 ` Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 2/5] test/test-acl: " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 3/5] test/test-pipeline: " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 4/5] test/bpf: move to examples folder Bruce Richardson
2019-02-20 9:35 ` Ananyev, Konstantin
2019-02-20 9:39 ` Bruce Richardson
2019-02-20 9:42 ` Ananyev, Konstantin
2019-02-20 10:35 ` Thomas Monjalon
2019-02-25 16:22 ` Ananyev, Konstantin
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 5/5] test/test: move to app folder Bruce Richardson
2019-02-20 11:47 ` [dpdk-dev] [PATCH v2 0/5] consolidate testing apps to app dir Ferruh Yigit
2019-02-25 15:34 ` Bruce Richardson
2019-02-26 12:18 ` [dpdk-dev] [PATCH v3 " Bruce Richardson
2019-02-26 12:18 ` [dpdk-dev] [PATCH v3 1/5] test/cmdline_test: move to app directory Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 2/5] test/test-acl: " Bruce Richardson
2019-02-26 12:27 ` Ananyev, Konstantin
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 3/5] test/test-pipeline: " Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 4/5] test/bpf: move to examples folder Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 5/5] test/test: move to app folder Bruce Richardson
2019-02-26 14:40 ` [dpdk-dev] [PATCH v3 0/5] consolidate testing apps to app dir Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129115229.GA80176@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).