From: Bruce Richardson <bruce.richardson@intel.com>
To: Chas Williams <3chas3@gmail.com>
Cc: dev@dpdk.org, thomas@monjalon.net, Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH] build: add option to override max ethports
Date: Mon, 4 Feb 2019 10:46:33 +0100 [thread overview]
Message-ID: <20190204094633.GB21148@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <23a3a256-0347-f6ed-c2b8-d923d7a6749d@gmail.com>
On Thu, Jan 31, 2019 at 06:26:41PM -0500, Chas Williams wrote:
>
>
> On 1/31/19 4:32 AM, Bruce Richardson wrote:
> > On Wed, Jan 30, 2019 at 09:18:58PM -0500, Chas Williams wrote:
> > > Allow users and packagers to override the default RTE_MAX_ETHPORTS.
> > > This adds a new meson option, max_ethports which defaults to the
> > > current value.
> > >
> > > Signed-off-by: Chas Williams <3chas3@gmail.com>
> >
> > Agree with the idea. Just one small comment below re alphabetical order.
> >
> > Otherwise:
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> ...
> >
> > We are trying to keep the options in alphabetical order, so this setting
> > should be just before "max_lcores" rather than at the end.
>
> If you look at the last few lines in this file:
>
> option('use_hpet', type: 'boolean', value: false,
> description: 'use HPET timer in EAL')
> option('tests', type: 'boolean', value: true,
> description: 'build unit tests')
>
> I couldn't detect any ordering so I just appended. I can submit a v2.
Yes, that was an oversight that was missed when we were adding those
options, or I just got my alphabet scrambled in my mind. :-) Thanks for the
v2.
>
> > Interestingly, I see that since 0.45 there is now the option of an
> > "integer" option type. We should probably switch to use that once we bump
> > our minimum meson version. [Luca, perhaps another change for your set?]
> > Ref: http://mesonbuild.com/Build-options.html#integers
>
> I just followed along with what everyone else was doing.
Yep, no problem here. Since we still support from 0.41 onwards we can't use
integer anyway, so what you did is perfectly correct.
next prev parent reply other threads:[~2019-02-04 9:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 2:18 Chas Williams
2019-01-31 9:32 ` Bruce Richardson
2019-01-31 23:26 ` Chas Williams
2019-02-04 9:46 ` Bruce Richardson [this message]
2019-02-06 17:10 ` Luca Boccassi
2019-01-31 23:53 ` [dpdk-dev] [PATCH 1/2 v2] " Chas Williams
2019-02-04 9:49 ` Bruce Richardson
2019-02-05 21:08 ` Chas Williams
2019-01-31 23:59 ` [dpdk-dev] [PATCH 2/2,v2] build: fix option ordering Chas Williams
2019-02-04 9:56 ` Bruce Richardson
2019-02-07 15:53 ` [dpdk-dev] [v3, PATCH 1/2] build: add option to override max ethports Chas Williams
2019-02-07 15:53 ` [dpdk-dev] [v3,PATCH 2/2] build: fix option ordering Chas Williams
2019-02-07 16:35 ` Bruce Richardson
2019-02-26 20:31 ` Thomas Monjalon
2019-02-26 20:19 ` [dpdk-dev] [v3, PATCH 1/2] build: add option to override max ethports Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204094633.GB21148@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=3chas3@gmail.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).