From: Bruce Richardson <bruce.richardson@intel.com>
To: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
Cc: dev@dpdk.org, reshma.pattan@intel.com ,
cristian.dumitrescu@intel.com,
jananeex.m.parthasarathy@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] lib: fix strcat with equivalent logic
Date: Thu, 14 Feb 2019 14:00:19 +0000 [thread overview]
Message-ID: <20190214140019.GA734836@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1550136631-32415-1-git-send-email-tallurix.chaitanya.babu@intel.com>
On Thu, Feb 14, 2019 at 09:30:31AM +0000, Chaitanya Babu Talluri wrote:
> Replace strcat with concatenation logic to avoid buffer overflow.
>
> Fixes: a6a47ac9c2 ("cfgfile: rework load function")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
> ---
> lib/librte_cfgfile/rte_cfgfile.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c
> index 7d8c941ea..7616742f7 100644
> --- a/lib/librte_cfgfile/rte_cfgfile.c
> +++ b/lib/librte_cfgfile/rte_cfgfile.c
> @@ -227,7 +227,15 @@ rte_cfgfile_load_with_params(const char *filename, int flags,
> while (end != NULL) {
> if (*(end+1) == params->comment_character) {
> *end = '\0';
> - strcat(split[1], end+1);
> + int index = strlen(split[1]);
> + char *temp = end+1;
> + while (*temp != '\0') {
> + split[1][index] = *temp;
> + index++;
> + temp++;
> + }
> + split[1][index] = '\0';
> +
I don't see how this change fixes the problem. From what I see, you have
just inlined the strcat function into the code above, without changing any
of the logic. To prevent buffer overflows using strcat, you need to
identify the total buffer length and use that when copying. I suggest
reworking this code to use strlcat.
/Bruce
next prev parent reply other threads:[~2019-02-14 14:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 9:30 [dpdk-stable] " Chaitanya Babu Talluri
2019-02-14 14:00 ` Bruce Richardson [this message]
2019-03-08 12:45 ` [dpdk-stable] [PATCH v2] lib/cfgfile: replace strcat with strlcat Chaitanya Babu Talluri
2019-03-08 14:02 ` Bruce Richardson
2019-03-08 17:30 ` Ferruh Yigit
[not found] ` <761FB0F2AB727F4FA9CE98D18810B0151B1F18AA@BGSMSX103.gar.corp.intel.com>
2019-03-27 11:37 ` Ferruh Yigit
2019-04-05 12:53 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214140019.GA734836@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=tallurix.chaitanya.babu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).