From: Bruce Richardson <bruce.richardson@intel.com>
To: Andrius Sirvys <andrius.sirvys@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] meson: fix building subdirectories separately
Date: Tue, 5 Mar 2019 17:26:23 +0000 [thread overview]
Message-ID: <20190305172623.GB103192@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20190305172111.GA103192@bricha3-MOBL.ger.corp.intel.com>
On Tue, Mar 05, 2019 at 05:21:12PM +0000, Bruce Richardson wrote:
> On Tue, Mar 05, 2019 at 04:29:25PM +0000, Andrius Sirvys wrote:
> > If for debugging we disable the driver directory in the meson.build file,
> > we get an error because the variable "driver_classes" does not exist.
> > This is because driver_classes is only defined in the
> > drivers/meson.build file. Defining driver_classes in dpdk/meson.build file
> > will make it easier for compiling separate directories.
> >
> > In the process, we rename driver_classes to dpdk_driver_classes for
> > consistency with the other variables.
> >
> > Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> > ---
> > v2: Fixed mispellings in commit message
> > ---
> This can be useful, and a similar change I saw in the windows RFC since it
> is incrementally adding things to the windows build, and so would hit this
> error.
>
> Therefore,
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Actually, one small thing I should have picked up on earlier - I think the
title could be reworded a bit. It's not a fix since there is nothing
technically wrong with the existing code - it's just harder to go
commenting out parts of the build without this change. How about setting
the title to: "build: move variable definition to top level", or something
similar.
/Bruce
next prev parent reply other threads:[~2019-03-05 17:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 16:29 Andrius Sirvys
2019-03-05 17:21 ` Bruce Richardson
2019-03-05 17:26 ` Bruce Richardson [this message]
2019-03-05 18:01 ` Ranjit Menon
2019-03-07 9:56 ` [dpdk-dev] [PATCH v3] build: move variable definition to top level Andrius Sirvys
2019-03-07 10:18 ` Bruce Richardson
2019-03-07 11:28 ` [dpdk-dev] [PATCH v4] " Andrius Sirvys
2019-03-24 22:59 ` Thomas Monjalon
2019-03-24 22:59 ` Thomas Monjalon
2019-03-25 10:34 ` [dpdk-dev] [PATCH v5] " Andrius Sirvys
2019-03-25 10:34 ` Andrius Sirvys
2019-03-26 22:16 ` Thomas Monjalon
2019-03-26 22:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305172623.GB103192@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=andrius.sirvys@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).