From: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"Joyce Kong (Arm Technology China)" <Joyce.Kong@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] rwlock: reimplement with atomic builtins
Date: Fri, 15 Mar 2019 03:04:47 +0000 [thread overview]
Message-ID: <VI1PR08MB3167C5C3DE4105E31FA946C68F440@VI1PR08MB3167.eurprd08.prod.outlook.com> (raw)
Message-ID: <20190315030447.nJP6-p8viZcJKWSCF-yQCZxM-hyYWcIEvhfqvKSXjuQ@z> (raw)
In-Reply-To: <20190314085429.22ccd9ca@shemminger-XPS-13-9360>
Hi Stephen,
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Thursday, March 14, 2019 11:54 PM
> To: Joyce Kong (Arm Technology China) <Joyce.Kong@arm.com>
> Cc: dev@dpdk.org; nd <nd@arm.com>; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>; jerinj@marvell.com; konstantin.ananyev@intel.com;
> chaozhu@linux.vnet.ibm.com; bruce.richardson@intel.com;
> thomas@monjalon.net; hemant.agrawal@nxp.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>
> Subject: Re: [dpdk-dev] [PATCH v3 1/3] rwlock: reimplement with atomic
> builtins
>
> On Thu, 14 Mar 2019 21:15:02 +0800
> Joyce Kong <joyce.kong@arm.com> wrote:
>
> > - success = rte_atomic32_cmpset((volatile uint32_t *)&rwl-
> >cnt,
> > - (uint32_t)x, (uint32_t)(x + 1));
> > + success = __atomic_compare_exchange_n(&rwl->cnt, &x,
> x+1, 1,
> > + __ATOMIC_ACQUIRE,
> __ATOMIC_RELAXED);
>
> Would it be possible to have rte_atomic32_cmpset be an inline function
> that became __atomic_comppare_exchange? Then all usages would be the
> same.
There is already a patch for this and Honnappa commented on this:
https://mails.dpdk.org/archives/dev/2019-January/124297.html
next prev parent reply other threads:[~2019-03-15 3:04 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 3:37 [dpdk-dev] [PATCH v1 0/2] reimplement rwlock and add relevant perf test case Joyce Kong
2018-12-13 3:37 ` [dpdk-dev] [PATCH v1 1/2] test/rwlock: add " Joyce Kong
2018-12-19 23:34 ` Ananyev, Konstantin
2018-12-20 1:01 ` Gavin Hu (Arm Technology China)
2018-12-20 1:45 ` Honnappa Nagarahalli
2019-03-14 13:15 ` [dpdk-dev] [PATCH v3 0/3] rwlock: reimplement rwlock with atomic and add relevant " Joyce Kong
2019-03-14 13:15 ` Joyce Kong
2019-03-14 13:15 ` [dpdk-dev] [PATCH v3 1/3] rwlock: reimplement with atomic builtins Joyce Kong
2019-03-14 13:15 ` Joyce Kong
2019-03-14 15:54 ` Stephen Hemminger
2019-03-14 15:54 ` Stephen Hemminger
2019-03-15 3:04 ` Gavin Hu (Arm Technology China) [this message]
2019-03-15 3:04 ` Gavin Hu (Arm Technology China)
2019-03-15 11:41 ` Ananyev, Konstantin
2019-03-15 11:41 ` Ananyev, Konstantin
2019-03-19 8:31 ` Gavin Hu (Arm Technology China)
2019-03-19 8:31 ` Gavin Hu (Arm Technology China)
2019-03-14 13:15 ` [dpdk-dev] [PATCH v3 2/3] test/rwlock: add perf test case on all available cores Joyce Kong
2019-03-14 13:15 ` Joyce Kong
2019-03-14 13:15 ` [dpdk-dev] [PATCH v3 3/3] test/rwlock: amortize the cost of getting time Joyce Kong
2019-03-14 13:15 ` Joyce Kong
2019-03-14 15:02 ` Honnappa Nagarahalli
2019-03-14 15:02 ` Honnappa Nagarahalli
2019-03-20 6:25 ` [dpdk-dev] [PATCH v4 0/3] rwlock: reimplement rwlock with atomic and add relevant perf test case Joyce Kong
2019-03-20 6:25 ` Joyce Kong
2019-03-20 6:25 ` [dpdk-dev] [PATCH v4 1/3] rwlock: reimplement with atomic builtins Joyce Kong
2019-03-20 6:25 ` Joyce Kong
2019-03-21 18:43 ` Ananyev, Konstantin
2019-03-21 18:43 ` Ananyev, Konstantin
2019-03-25 9:18 ` Joyce Kong (Arm Technology China)
2019-03-25 9:18 ` Joyce Kong (Arm Technology China)
2019-03-20 6:25 ` [dpdk-dev] [PATCH v4 2/3] test/rwlock: add perf test case on all available cores Joyce Kong
2019-03-20 6:25 ` Joyce Kong
2019-03-21 18:44 ` Ananyev, Konstantin
2019-03-21 18:44 ` Ananyev, Konstantin
2019-03-20 6:25 ` [dpdk-dev] [PATCH v4 3/3] test/rwlock: amortize the cost of getting time Joyce Kong
2019-03-20 6:25 ` Joyce Kong
2019-03-21 18:44 ` Ananyev, Konstantin
2019-03-21 18:44 ` Ananyev, Konstantin
2019-03-25 9:14 ` [dpdk-dev] [PATCH v5 0/3] rwlock: reimplement rwlock with atomic and add relevant perf test case Joyce Kong
2019-03-25 9:14 ` Joyce Kong
2019-03-28 10:50 ` Thomas Monjalon
2019-03-28 10:50 ` Thomas Monjalon
2019-04-16 14:57 ` Kevin Traynor
2019-04-16 14:57 ` Kevin Traynor
2019-03-25 9:14 ` [dpdk-dev] [PATCH v5 1/3] rwlock: reimplement with atomic builtins Joyce Kong
2019-03-25 9:14 ` Joyce Kong
2019-03-25 9:14 ` [dpdk-dev] [PATCH v5 2/3] test/rwlock: add perf test case on all available cores Joyce Kong
2019-03-25 9:14 ` Joyce Kong
2019-03-25 9:14 ` [dpdk-dev] [PATCH v5 3/3] test/rwlock: amortize the cost of getting time Joyce Kong
2019-03-25 9:14 ` Joyce Kong
2018-12-13 3:37 ` [dpdk-dev] [PATCH v1 2/2] rwlock: reimplement with __atomic builtins Joyce Kong
2018-12-19 23:50 ` Ananyev, Konstantin
2018-12-13 5:27 ` [dpdk-dev] [PATCH v1 0/2] reimplement rwlock and add relevant perf test case Stephen Hemminger
2018-12-14 1:30 ` Gavin Hu (Arm Technology China)
2018-12-17 5:16 ` Honnappa Nagarahalli
2018-12-19 20:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR08MB3167C5C3DE4105E31FA946C68F440@VI1PR08MB3167.eurprd08.prod.outlook.com \
--to=gavin.hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Joyce.Kong@arm.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).