DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hajkowski <marcinx.hajkowski@intel.com>
To: david.hunt@intel.com
Cc: dev@dpdk.org, Marcin Hajkowski <marcinx.hajkowski@intel.com>
Subject: [dpdk-dev] [PATCH 3/4] power: reset function pointers on unset env
Date: Fri, 15 Mar 2019 10:34:19 +0100	[thread overview]
Message-ID: <20190315093420.9812-4-marcinx.hajkowski@intel.com> (raw)
Message-ID: <20190315093419.GT_6dFz0KIq8CYvyr6gX8IMS-8mZmasS1hn-U1SQzbY@z> (raw)
In-Reply-To: <20190315093420.9812-1-marcinx.hajkowski@intel.com>

From: Marcin Hajkowski <marcinx.hajkowski@intel.com>

Set all power environment related function pointers to NULL
when unset is being made.

Signed-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>
---
 lib/librte_power/rte_power.c | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/lib/librte_power/rte_power.c b/lib/librte_power/rte_power.c
index ed701087d..6b7722727 100644
--- a/lib/librte_power/rte_power.c
+++ b/lib/librte_power/rte_power.c
@@ -27,6 +27,22 @@ rte_power_freq_change_t rte_power_freq_enable_turbo;
 rte_power_freq_change_t rte_power_freq_disable_turbo;
 rte_power_get_capabilities_t rte_power_get_capabilities;
 
+static void
+reset_power_function_ptrs(void)
+{
+	rte_power_freqs  = NULL;
+	rte_power_get_freq = NULL;
+	rte_power_set_freq = NULL;
+	rte_power_freq_up = NULL;
+	rte_power_freq_down = NULL;
+	rte_power_freq_max = NULL;
+	rte_power_freq_min = NULL;
+	rte_power_turbo_status = NULL;
+	rte_power_freq_enable_turbo = NULL;
+	rte_power_freq_disable_turbo = NULL;
+	rte_power_get_capabilities = NULL;
+}
+
 int
 rte_power_set_env(enum power_management_env env)
 {
@@ -85,8 +101,10 @@ rte_power_set_env(enum power_management_env env)
 
 	if (ret == 0)
 		global_default_env = env;
-	else
+	else {
 		global_default_env = PM_ENV_NOT_SET;
+		reset_power_function_ptrs();
+	}
 
 	rte_spinlock_unlock(&global_env_cfg_lock);
 	return ret;
@@ -97,6 +115,7 @@ rte_power_unset_env(void)
 {
 	rte_spinlock_lock(&global_env_cfg_lock);
 	global_default_env = PM_ENV_NOT_SET;
+	reset_power_function_ptrs();
 	rte_spinlock_unlock(&global_env_cfg_lock);
 }
 
-- 
2.17.2


  parent reply	other threads:[~2019-03-15  9:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15  9:34 [dpdk-dev] [PATCH 0/4] rte_power APIs enhancement Hajkowski
2019-03-15  9:34 ` Hajkowski
2019-03-15  9:34 ` [dpdk-dev] [PATCH 1/4] power: fix non thread-safe power env modification Hajkowski
2019-03-15  9:34   ` Hajkowski
2019-03-15  9:34 ` [dpdk-dev] [PATCH 2/4] power: return error in set env when power env already set Hajkowski
2019-03-15  9:34   ` Hajkowski
2019-03-15  9:34 ` Hajkowski [this message]
2019-03-15  9:34   ` [dpdk-dev] [PATCH 3/4] power: reset function pointers on unset env Hajkowski
2019-03-15  9:34 ` [dpdk-dev] [PATCH 4/4] power: add UTs for all power env types Hajkowski
2019-03-15  9:34   ` Hajkowski
  -- strict thread matches above, loose matches on Subject: below --
2019-03-13 19:48 [dpdk-dev] [PATCH 0/4] rte_power APIs enhancement Hajkowski
2019-03-13 19:48 ` [dpdk-dev] [PATCH 3/4] power: reset function pointers on unset env Hajkowski
2019-03-13 19:48   ` Hajkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190315093420.9812-4-marcinx.hajkowski@intel.com \
    --to=marcinx.hajkowski@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).