From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Kovacevic, Marko" <marko.kovacevic@intel.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Nowak, DamianX" <damianx.nowak@intel.com>
Subject: Re: [dpdk-dev] [PATCH] fips_validation: Add plain SHA support
Date: Sun, 17 Mar 2019 18:08:00 +0000 [thread overview]
Message-ID: <8b1c4e65-5444-a969-9964-95b317983853@nxp.com> (raw)
Message-ID: <20190317180800.fxG_OEILek8a7kwr7IanO7MMSwKVn1k49CafSQmZHQk@z> (raw)
In-Reply-To: <6DC05C7C5F25994B81B3F2F214251F66020A3F5C@IRSMSX104.ger.corp.intel.com>
Hi Damian,
On 3/7/2019 9:14 PM, Kovacevic, Marko wrote:
>> From: Damian Nowak <damianx.nowak@intel.com>
>>
>> This patch enables plain SHA algorithm CAVP test support in fips_validation
>> sample application.
>>
>> Signed-off-by: Damian Nowak <damianx.nowak@intel.com>
>> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
>> ---
>> examples/fips_validation/Makefile | 1 +
>> examples/fips_validation/fips_validation.c | 17 ++++
>> examples/fips_validation/fips_validation.h | 17 +++-
>> examples/fips_validation/fips_validation_sha.c | 110
>> +++++++++++++++++++++++
> All looks fine but the warnings can be avoided.
> You can inherit my ack
>
> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
could you please send another version with warnings removed?
Thanks.
next prev parent reply other threads:[~2019-03-17 18:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 15:54 Fan Zhang
2019-03-07 15:44 ` Kovacevic, Marko
2019-03-17 18:08 ` Akhil Goyal [this message]
2019-03-17 18:08 ` Akhil Goyal
2019-03-19 9:43 ` [dpdk-dev] [PATCH v2 0/1] " Damian Nowak
2019-03-19 9:43 ` Damian Nowak
2019-03-19 9:43 ` [dpdk-dev] [PATCH v2 1/1] " Damian Nowak
2019-03-19 9:43 ` Damian Nowak
2019-03-22 15:06 ` Akhil Goyal
2019-03-22 15:06 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b1c4e65-5444-a969-9964-95b317983853@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=damianx.nowak@intel.com \
--cc=dev@dpdk.org \
--cc=marko.kovacevic@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).