From: Akhil Goyal <akhil.goyal@nxp.com>
To: Fan Zhang <roy.fan.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/4] ipsec: add 3DES-CBC algorithm support
Date: Tue, 19 Mar 2019 14:46:07 +0000 [thread overview]
Message-ID: <a84635ac-c3dd-a380-3d95-3d9d44b2035f@nxp.com> (raw)
Message-ID: <20190319144607.l86uHuiAwjd1ncrIO_IdJHP2ZZuQCwvj0PjwEPZaHtQ@z> (raw)
In-Reply-To: <20190219153236.84537-4-roy.fan.zhang@intel.com>
On 2/19/2019 9:02 PM, Fan Zhang wrote:
> This patch adds triple-des CBC mode cipher algorithm to ipsec
> library.
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> lib/librte_ipsec/sa.c | 10 ++++++++++
> lib/librte_ipsec/sa.h | 6 ++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/lib/librte_ipsec/sa.c b/lib/librte_ipsec/sa.c
> index e34dd320a..5c59c4b67 100644
> --- a/lib/librte_ipsec/sa.c
> +++ b/lib/librte_ipsec/sa.c
> @@ -307,6 +307,13 @@ esp_sa_init(struct rte_ipsec_sa *sa, const struct rte_ipsec_sa_prm *prm,
> sa->algo_type = ALGO_TYPE_AES_CTR;
> break;
>
> + case RTE_CRYPTO_CIPHER_3DES_CBC:
> + /* RFC 1851 */
> + sa->pad_align = IPSEC_PAD_3DES_CBC;
> + sa->iv_len = IPSEC_3DES_IV_SIZE;
> + sa->algo_type = ALGO_TYPE_3DES;
> + break;
> +
> default:
> return -EINVAL;
> }
> @@ -512,6 +519,8 @@ esp_outb_cop_prepare(struct rte_crypto_op *cop,
> sa->iv_ofs);
> aes_ctr_cnt_blk_fill(ctr, ivp[0], sa->salt);
> break;
> + case ALGO_TYPE_3DES:
> + /* Cipher-Auth (3DES-CBC *) case */
> case ALGO_TYPE_NULL:
> /* NULL case */
> sop->cipher.data.offset = sa->ctp.cipher.offset + hlen;
> @@ -873,6 +882,7 @@ esp_inb_tun_cop_prepare(struct rte_crypto_op *cop,
> aead_gcm_iv_fill(gcm, ivp[0], sa->salt);
> break;
> case ALGO_TYPE_AES_CBC:
> + case ALGO_TYPE_3DES:
> sop->cipher.data.offset = pofs + sa->ctp.cipher.offset;
> sop->cipher.data.length = clen;
> sop->auth.data.offset = pofs + sa->ctp.auth.offset;
> diff --git a/lib/librte_ipsec/sa.h b/lib/librte_ipsec/sa.h
> index 12c061ee6..8398748d1 100644
> --- a/lib/librte_ipsec/sa.h
> +++ b/lib/librte_ipsec/sa.h
> @@ -14,6 +14,7 @@
> /* padding alignment for different algorithms */
> enum {
> IPSEC_PAD_DEFAULT = 4,
> + IPSEC_PAD_3DES_CBC = IPSEC_PAD_DEFAULT,
> IPSEC_PAD_AES_CBC = IPSEC_MAX_IV_SIZE,
> IPSEC_PAD_AES_CTR = IPSEC_PAD_DEFAULT,
> IPSEC_PAD_AES_GCM = IPSEC_PAD_DEFAULT,
> @@ -24,6 +25,10 @@ enum {
> enum {
> IPSEC_IV_SIZE_DEFAULT = IPSEC_MAX_IV_SIZE,
> IPSEC_AES_CTR_IV_SIZE = sizeof(uint64_t),
> + /* TripleDES supports IV size of 32bits or 64bits but he library
> + * only supports 64bits.
> + */
> + IPSEC_3DES_IV_SIZE = sizeof(uint64_t),
> };
>
> /* these definitions probably has to be in rte_crypto_sym.h */
> @@ -57,6 +62,7 @@ struct replay_sqn {
> /*IPSEC SA supported algorithms */
> enum sa_algo_type {
> ALGO_TYPE_NULL = 0,
> + ALGO_TYPE_3DES,
this should be 3des_cbc
> ALGO_TYPE_AES_CBC,
> ALGO_TYPE_AES_CTR,
> ALGO_TYPE_AES_GCM,
next prev parent reply other threads:[~2019-03-19 14:46 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 16:32 [dpdk-dev] [PATCH 0/4] ipsec: add AES-CTR and 3DES-CBC support Fan Zhang
2019-02-18 16:32 ` [dpdk-dev] [PATCH 1/4] ipsec: add AES-CTR algorithm support Fan Zhang
2019-02-18 16:32 ` [dpdk-dev] [PATCH 2/4] ipsec-secgw: add test scripts for aes ctr Fan Zhang
2019-02-18 16:32 ` [dpdk-dev] [PATCH 3/4] ipsec: add 3DES-CBC algorithm support Fan Zhang
2019-02-18 16:32 ` [dpdk-dev] [PATCH 4/4] ipsec-secgw: add 3des test files Fan Zhang
2019-02-19 15:32 ` [dpdk-dev] [PATCH v2 0/4] ipsec: add AES-CTR and 3DES-CBC support Fan Zhang
2019-02-19 15:32 ` [dpdk-dev] [PATCH v2 1/4] ipsec: add AES-CTR algorithm support Fan Zhang
2019-02-22 12:43 ` Ananyev, Konstantin
2019-03-19 14:32 ` Akhil Goyal
2019-03-19 14:32 ` Akhil Goyal
2019-02-19 15:32 ` [dpdk-dev] [PATCH v2 2/4] ipsec-secgw: add test scripts for aes ctr Fan Zhang
2019-02-22 12:39 ` Ananyev, Konstantin
2019-02-19 15:32 ` [dpdk-dev] [PATCH v2 3/4] ipsec: add 3DES-CBC algorithm support Fan Zhang
2019-02-22 12:38 ` Ananyev, Konstantin
2019-03-19 14:46 ` Akhil Goyal [this message]
2019-03-19 14:46 ` Akhil Goyal
2019-02-19 15:32 ` [dpdk-dev] [PATCH v2 4/4] ipsec-secgw: add 3des test files Fan Zhang
2019-02-22 12:40 ` Ananyev, Konstantin
2019-02-25 12:07 ` [dpdk-dev] [PATCH v3 0/4] ipsec: add AES-CTR and 3DES-CBC support Fan Zhang
2019-02-25 12:07 ` [dpdk-dev] [PATCH v3 1/4] ipsec: add AES-CTR algorithm support Fan Zhang
2019-02-25 12:07 ` [dpdk-dev] [PATCH v3 2/4] ipsec-secgw: add test scripts for aes ctr Fan Zhang
2019-02-25 12:07 ` [dpdk-dev] [PATCH v3 3/4] ipsec: add 3DES-CBC algorithm support Fan Zhang
2019-02-25 12:07 ` [dpdk-dev] [PATCH v3 4/4] ipsec-secgw: add 3des test files Fan Zhang
2019-03-04 16:38 ` [dpdk-dev] [PATCH v3 0/4] ipsec: add AES-CTR and 3DES-CBC support Ananyev, Konstantin
2019-03-20 13:51 ` [dpdk-dev] [PATCH v4 0/4] ipsec: support AES-CTR and 3DES-CBC Fan Zhang
2019-03-20 13:51 ` Fan Zhang
2019-03-20 13:51 ` [dpdk-dev] [PATCH v4 1/4] ipsec: support AES-CTR Fan Zhang
2019-03-20 13:51 ` Fan Zhang
2019-03-20 13:51 ` [dpdk-dev] [PATCH v4 2/4] ipsec-secgw: add test scripts for aes ctr Fan Zhang
2019-03-20 13:51 ` Fan Zhang
2019-03-20 13:51 ` [dpdk-dev] [PATCH v4 3/4] ipsec: support 3DES-CBC Fan Zhang
2019-03-20 13:51 ` Fan Zhang
2019-03-20 13:51 ` [dpdk-dev] [PATCH v4 4/4] ipsec-secgw: add 3des test files Fan Zhang
2019-03-20 13:51 ` Fan Zhang
2019-03-20 15:38 ` [dpdk-dev] [PATCH v5 0/5] ipsec: support AES-CTR and 3DES-CBC Fan Zhang
2019-03-20 15:38 ` Fan Zhang
2019-03-20 15:38 ` [dpdk-dev] [PATCH v5 1/5] ipsec: support AES-CTR Fan Zhang
2019-03-20 15:38 ` Fan Zhang
2019-03-22 11:53 ` Akhil Goyal
2019-03-22 11:53 ` Akhil Goyal
2019-03-22 12:46 ` Ananyev, Konstantin
2019-03-22 12:46 ` Ananyev, Konstantin
2019-03-22 13:01 ` Akhil Goyal
2019-03-22 13:01 ` Akhil Goyal
2019-03-20 15:38 ` [dpdk-dev] [PATCH v5 2/5] ipsec-secgw: add test scripts for aes ctr Fan Zhang
2019-03-20 15:38 ` Fan Zhang
2019-03-20 15:38 ` [dpdk-dev] [PATCH v5 3/5] ipsec: support 3DES-CBC Fan Zhang
2019-03-20 15:38 ` Fan Zhang
2019-03-20 15:38 ` [dpdk-dev] [PATCH v5 4/5] ipsec-secgw: add 3des test files Fan Zhang
2019-03-20 15:38 ` Fan Zhang
2019-03-20 15:38 ` [dpdk-dev] [PATCH v5 5/5] doc: update release note Fan Zhang
2019-03-20 15:38 ` Fan Zhang
2019-03-22 14:59 ` [dpdk-dev] [PATCH v5 0/5] ipsec: support AES-CTR and 3DES-CBC Akhil Goyal
2019-03-22 14:59 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a84635ac-c3dd-a380-3d95-3d9d44b2035f@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).