From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, i.maximets@samsung.com, changpeng.liu@intel.com,
dariusz.stojaczyk@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 2/2] vhost: support requests only handled by external backend
Date: Wed, 20 Mar 2019 12:54:48 +0800 [thread overview]
Message-ID: <20190320045447.GA26570@dpdk-tbie.sh.intel.com> (raw)
In-Reply-To: <20190319105417.16890-3-maxime.coquelin@redhat.com>
On Tue, Mar 19, 2019 at 11:54:17AM +0100, Maxime Coquelin wrote:
> External backends may have specific requests to handle, and so
> we don't want the vhost-user lib to handle these requests as
> errors.
>
> This patch also changes the experimental API by introducing
> RTE_VHOST_MSG_RESULT_NOT_HANDLED so that vhost-user lib
> can report an error if a message is handled neither by
> the vhost-user library nor by the external backend.
>
> The logic changes a bit so that if the callback returns
> with ERR, OK or REPLY, it is considered the message
> is handled by the external backend so it won't be
> handled by the vhost-user library.
> It is still possible for an external backend to listen
> to requests that have to be handled by the vhost-user
> library like SET_MEM_TABLE, but the callback have to
> return NOT_HANDLED in that case.
>
> Vhost-crypto backend is ialso adapted to this API change.
>
> Suggested-by: Ilya Maximets <i.maximets@samsung.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> Tested-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> ---
> lib/librte_vhost/rte_vhost.h | 39 ++++++----------
> lib/librte_vhost/vhost_crypto.c | 10 +++-
> lib/librte_vhost/vhost_user.c | 82 +++++++++++++++++++++------------
> 3 files changed, 73 insertions(+), 58 deletions(-)
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
next prev parent reply other threads:[~2019-03-20 4:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 10:54 [dpdk-dev] [PATCH v3 0/2] vhost: Support external backend only vhost-user requests Maxime Coquelin
2019-03-19 10:54 ` Maxime Coquelin
2019-03-19 10:54 ` [dpdk-dev] [PATCH v3 1/2] vhost: add API to set protocol features flags Maxime Coquelin
2019-03-19 10:54 ` Maxime Coquelin
2019-03-19 10:54 ` [dpdk-dev] [PATCH v3 2/2] vhost: support requests only handled by external backend Maxime Coquelin
2019-03-19 10:54 ` Maxime Coquelin
2019-03-20 4:54 ` Tiwei Bie [this message]
2019-03-20 4:54 ` Tiwei Bie
2019-03-20 7:34 ` [dpdk-dev] [PATCH v3 0/2] vhost: Support external backend only vhost-user requests Maxime Coquelin
2019-03-20 7:34 ` Maxime Coquelin
2019-03-20 14:32 ` Stojaczyk, Dariusz
2019-03-20 14:32 ` Stojaczyk, Dariusz
2019-03-21 9:21 ` Maxime Coquelin
2019-03-21 9:21 ` Maxime Coquelin
2019-03-22 10:29 ` Zhang, Roy Fan
2019-03-22 10:29 ` Zhang, Roy Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320045447.GA26570@dpdk-tbie.sh.intel.com \
--to=tiwei.bie@intel.com \
--cc=changpeng.liu@intel.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).