DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jens Freimann <jfreimann@redhat.com>
Cc: dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,
	ktraynor@redhat.com, stephen@networkplumber.org
Subject: Re: [dpdk-dev] [RFC] net/virtio: remove prefix from virtqueue struct fields
Date: Thu, 21 Mar 2019 15:17:22 +0100	[thread overview]
Message-ID: <9915b6b7-8e59-80a2-e58d-0fddeb244786@redhat.com> (raw)
Message-ID: <20190321141722.itd9cG-LfY9sVs1iST4__7OqZ53PAk17iVTwLbSTV3c@z> (raw)
In-Reply-To: <20190321140244.bti7cizxpovyr3e6@jenstp.localdomain>



On 3/21/19 3:02 PM, Jens Freimann wrote:
> On Thu, Mar 21, 2019 at 02:45:20PM +0100, Maxime Coquelin wrote:
>> Most of 'virtqueue' struct fields are prefixed with 'vq_'.
>> This redundant, this patch removes them all.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> Hi,
>>
>> Following our discussions on removing the 'vq_' prefix, I did
>> the patch to see how it would look like.
>>
>> It looks like it does not prevent any lines to be split but one.
>> But the code is more readable IMHO.
>>
>> I send this as RFC to get your feedback.
> 
> Yes, I think it's more readable.  One thing I had not thought about is
> that it makes it harder to find meaningful results from git blame
> output. Can we live with that?

That's a valid point, and I think it might be more problematic than the
conflicts for backporting, which would be trivial to solve.

I don't have a strong opinion on whether we should do it or not.

Thanks,
Maxime
> 
> regards,
> Jens

  parent reply	other threads:[~2019-03-21 14:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 13:45 Maxime Coquelin
2019-03-21 13:45 ` Maxime Coquelin
2019-03-21 14:02 ` Jens Freimann
2019-03-21 14:02   ` Jens Freimann
2019-03-21 14:17   ` Maxime Coquelin [this message]
2019-03-21 14:17     ` Maxime Coquelin
2019-03-22  7:10     ` Tiwei Bie
2019-03-22  7:10       ` Tiwei Bie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9915b6b7-8e59-80a2-e58d-0fddeb244786@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jfreimann@redhat.com \
    --cc=ktraynor@redhat.com \
    --cc=stephen@networkplumber.org \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).