DPDK patches and discussions
 help / color / mirror / Atom feed
From: Joyce Kong <joyce.kong@arm.com>
To: dev@dpdk.org
Cc: nd@arm.com, jerinj@marvell.com, konstantin.ananyev@intel.com,
	chaozhu@linux.vnet.ibm.com, bruce.richardson@intel.com,
	thomas@monjalon.net, hemant.agrawal@nxp.com,
	honnappa.nagarahalli@arm.com, gavin.hu@arm.com
Subject: [dpdk-dev] [PATCH v5 0/3] rwlock: reimplement rwlock with atomic and add relevant perf test case
Date: Mon, 25 Mar 2019 17:14:56 +0800	[thread overview]
Message-ID: <1553505299-34459-1-git-send-email-joyce.kong@arm.com> (raw)
Message-ID: <20190325091456.jHrvAOBzFCKmm8__GsgytUyF40lM_aKcI3z5K2IJ5zw@z> (raw)
In-Reply-To: <1544672265-219262-2-git-send-email-joyce.kong@arm.com>

v5: Minor format change.

v4: Change _try_ functions to use __atomic too (for consistency)(Suggested by Ananyev, Konstantin).

v3: Fix headline format error.

v2: Rebase and modify the rwlock test case to address the comments in v1.

v1: Reimplement rwlock with atomic builtins, and add a rwlock perf test
    on all available cores to benchmark the improvement.

	We tested the patches on three arm64 platforms.
	ThundeX2 gained 20% performance, Qualcomm gained 36% and
	the 4-Cortex-A72 Marvell MACCHIATObin gained 19.6%.
	
	Below is the detailed test result on ThunderX2:

	*** rwlock_autotest without atomic builtins ***
	Rwlock Perf Test on 128 cores...
	Core [0] count = 281
	Core [1] count = 252
	Core [2] count = 290
	Core [3] count = 259
	Core [4] count = 287
	...
	Core [209] count = 3
	Core [210] count = 31
	Core [211] count = 120
	Total count = 18537

	*** rwlock_autotest with atomic builtins ***
	Rwlock Perf Test on 128 cores...
	Core [0] count = 346
	Core [1] count = 355
	Core [2] count = 259
	Core [3] count = 285
	Core [4] count = 320
	...
	Core [209] count = 2
	Core [210] count = 23
	Core [211] count = 63
	Total count = 22194

Gavin Hu (1):
  rwlock: reimplement with atomic builtins

Joyce Kong (2):
  test/rwlock: add perf test case on all available cores
  test/rwlock: amortize the cost of getting time

 app/test/test_rwlock.c                             | 77 ++++++++++++++++++++++
 lib/librte_eal/common/include/generic/rte_rwlock.h | 29 ++++----
 2 files changed, 92 insertions(+), 14 deletions(-)

-- 
2.7.4


  parent reply	other threads:[~2019-03-25  9:15 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13  3:37 [dpdk-dev] [PATCH v1 0/2] reimplement rwlock " Joyce Kong
2018-12-13  3:37 ` [dpdk-dev] [PATCH v1 1/2] test/rwlock: add " Joyce Kong
2018-12-19 23:34   ` Ananyev, Konstantin
2018-12-20  1:01     ` Gavin Hu (Arm Technology China)
2018-12-20  1:45       ` Honnappa Nagarahalli
2019-03-14 13:15   ` [dpdk-dev] [PATCH v3 0/3] rwlock: reimplement rwlock with atomic and add relevant " Joyce Kong
2019-03-14 13:15     ` Joyce Kong
2019-03-14 13:15   ` [dpdk-dev] [PATCH v3 1/3] rwlock: reimplement with atomic builtins Joyce Kong
2019-03-14 13:15     ` Joyce Kong
2019-03-14 15:54     ` Stephen Hemminger
2019-03-14 15:54       ` Stephen Hemminger
2019-03-15  3:04       ` Gavin Hu (Arm Technology China)
2019-03-15  3:04         ` Gavin Hu (Arm Technology China)
2019-03-15 11:41     ` Ananyev, Konstantin
2019-03-15 11:41       ` Ananyev, Konstantin
2019-03-19  8:31       ` Gavin Hu (Arm Technology China)
2019-03-19  8:31         ` Gavin Hu (Arm Technology China)
2019-03-14 13:15   ` [dpdk-dev] [PATCH v3 2/3] test/rwlock: add perf test case on all available cores Joyce Kong
2019-03-14 13:15     ` Joyce Kong
2019-03-14 13:15   ` [dpdk-dev] [PATCH v3 3/3] test/rwlock: amortize the cost of getting time Joyce Kong
2019-03-14 13:15     ` Joyce Kong
2019-03-14 15:02     ` Honnappa Nagarahalli
2019-03-14 15:02       ` Honnappa Nagarahalli
2019-03-20  6:25   ` [dpdk-dev] [PATCH v4 0/3] rwlock: reimplement rwlock with atomic and add relevant perf test case Joyce Kong
2019-03-20  6:25     ` Joyce Kong
2019-03-20  6:25   ` [dpdk-dev] [PATCH v4 1/3] rwlock: reimplement with atomic builtins Joyce Kong
2019-03-20  6:25     ` Joyce Kong
2019-03-21 18:43     ` Ananyev, Konstantin
2019-03-21 18:43       ` Ananyev, Konstantin
2019-03-25  9:18       ` Joyce Kong (Arm Technology China)
2019-03-25  9:18         ` Joyce Kong (Arm Technology China)
2019-03-20  6:25   ` [dpdk-dev] [PATCH v4 2/3] test/rwlock: add perf test case on all available cores Joyce Kong
2019-03-20  6:25     ` Joyce Kong
2019-03-21 18:44     ` Ananyev, Konstantin
2019-03-21 18:44       ` Ananyev, Konstantin
2019-03-20  6:25   ` [dpdk-dev] [PATCH v4 3/3] test/rwlock: amortize the cost of getting time Joyce Kong
2019-03-20  6:25     ` Joyce Kong
2019-03-21 18:44     ` Ananyev, Konstantin
2019-03-21 18:44       ` Ananyev, Konstantin
2019-03-25  9:14   ` Joyce Kong [this message]
2019-03-25  9:14     ` [dpdk-dev] [PATCH v5 0/3] rwlock: reimplement rwlock with atomic and add relevant perf test case Joyce Kong
2019-03-28 10:50     ` Thomas Monjalon
2019-03-28 10:50       ` Thomas Monjalon
2019-04-16 14:57     ` Kevin Traynor
2019-04-16 14:57       ` Kevin Traynor
2019-03-25  9:14   ` [dpdk-dev] [PATCH v5 1/3] rwlock: reimplement with atomic builtins Joyce Kong
2019-03-25  9:14     ` Joyce Kong
2019-03-25  9:14   ` [dpdk-dev] [PATCH v5 2/3] test/rwlock: add perf test case on all available cores Joyce Kong
2019-03-25  9:14     ` Joyce Kong
2019-03-25  9:14   ` [dpdk-dev] [PATCH v5 3/3] test/rwlock: amortize the cost of getting time Joyce Kong
2019-03-25  9:14     ` Joyce Kong
2018-12-13  3:37 ` [dpdk-dev] [PATCH v1 2/2] rwlock: reimplement with __atomic builtins Joyce Kong
2018-12-19 23:50   ` Ananyev, Konstantin
2018-12-13  5:27 ` [dpdk-dev] [PATCH v1 0/2] reimplement rwlock and add relevant perf test case Stephen Hemminger
2018-12-14  1:30   ` Gavin Hu (Arm Technology China)
2018-12-17  5:16     ` Honnappa Nagarahalli
2018-12-19 20:37       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1553505299-34459-1-git-send-email-joyce.kong@arm.com \
    --to=joyce.kong@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=chaozhu@linux.vnet.ibm.com \
    --cc=dev@dpdk.org \
    --cc=gavin.hu@arm.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=jerinj@marvell.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=nd@arm.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).