DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wei Zhao <wei.zhao1@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, qi.z.zhang@intel.com, ferruh.yigit@intel.com,
	Wei Zhao <wei.zhao1@intel.com>
Subject: [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid
Date: Tue, 26 Mar 2019 16:35:24 +0800	[thread overview]
Message-ID: <1553589324-16990-1-git-send-email-wei.zhao1@intel.com> (raw)
Message-ID: <20190326083524.1tjMEFvNe6-uAQFX8ZiZFvtGkjnNDk8DwTQ6j1DKUsY@z> (raw)
In-Reply-To: <1553224009-36918-1-git-send-email-wei.zhao1@intel.com>

A log message is required when provided RSS key is
not valid so that driver will use the default RSS key.

Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Cc: stable@dpdk.org

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>

---

v2:
update dev info message

v3:
update log info
---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 63ec813..5472312 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		rss_conf.rss_key = (uint8_t *)rss_key_default;
 		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 							sizeof(uint32_t);
+		PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using default\n");
 	}
 
 	i40e_hw_rss_hash_set(pf, &rss_conf);
-- 
2.7.5


  parent reply	other threads:[~2019-03-26  9:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20  3:31 [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key Wei Zhao
2019-03-20  3:31 ` Wei Zhao
2019-03-20  9:21 ` Peng, Yuan
2019-03-20  9:21   ` Peng, Yuan
2019-03-20  9:23   ` Zhao1, Wei
2019-03-20  9:23     ` Zhao1, Wei
2019-03-20 12:20 ` Kevin Traynor
2019-03-20 12:20   ` Kevin Traynor
2019-03-22  1:27   ` Zhao1, Wei
2019-03-22  1:27     ` Zhao1, Wei
2019-03-22  2:16 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-03-22  2:16   ` Wei Zhao
2019-03-22  3:06 ` Wei Zhao
2019-03-22  3:06   ` Wei Zhao
2019-03-22 13:30   ` Zhang, Qi Z
2019-03-22 13:30     ` Zhang, Qi Z
2019-03-26  8:35   ` Wei Zhao [this message]
2019-03-26  8:35     ` [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid Wei Zhao
2019-03-26 12:41     ` Zhang, Qi Z
2019-03-26 12:41       ` Zhang, Qi Z
2019-03-26 14:51       ` Ferruh Yigit
2019-03-26 14:51         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1553589324-16990-1-git-send-email-wei.zhao1@intel.com \
    --to=wei.zhao1@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).